Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note how the SVG currently implemented in browsers is a mix of SVG 1.1 and SVG Tiny 1.2 #327

Closed
wants to merge 4 commits into from

Conversation

tigt
Copy link

@tigt tigt commented Nov 10, 2015

Browsers do not currently follow any specifications exactly, for
historical and practical reasons. This attempts to clarify what
features are best avoided, and what features can be relied on.

Discussion: #126

…1 and SVG Tiny 1.2

Browsers do not currently follow any specifications exactly, for
historical and practical reasons. This attempts to clarify what
features are best avoided, and what features can be relied on.

Discussion: #126
@annevk
Copy link
Member

annevk commented Nov 11, 2015

@heycam or @erikdahlstrom, would you be willing to review this change for accuracy?

@@ -37272,16 +37272,61 @@ dictionary <dfn>TrackEventInit</dfn> : <span>EventInit</span> {

</div>

<p>When the SVG <code data-x="">foreignObject</code> element contains elements from the <span>HTML
namespace</span>, such elements must all be <span>flow content</span>. <ref spec=SVG></p>
<p>When the SVG <code data-x="svg:foreignObject">foreignObject</code> element contains elements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are not referencing a <dfn>, just keep data-x set to the empty string. I don't think this change will go through the build script as-is.

Fixed `<code data-x=“”>` attributes to conform with the spec syntax.
@zcorpan
Copy link
Member

zcorpan commented Nov 16, 2015

Still an outstanding comment about removing the line

+  <p>Additionally, <code>data-*</code> attributes are allowed on all SVG elements.</p>

(Since no SVG spec AFAIK allows this yet.)

@zcorpan zcorpan removed their assignment Nov 16, 2015
tigt added 2 commits November 16, 2015 12:20
It works in all browsers, but has never been specced. Better to be on
the safe side.
@tigt
Copy link
Author

tigt commented Nov 16, 2015

@zcorpan Whoops, missed that.

@zcorpan
Copy link
Member

zcorpan commented Nov 16, 2015

Lgtm

@zcorpan zcorpan closed this in 969c45b Nov 17, 2015
@zcorpan
Copy link
Member

zcorpan commented Nov 17, 2015

Thank you @tigt!

@tigt
Copy link
Author

tigt commented Nov 17, 2015

No, thank you for being so helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants