-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example of output element to use ids instead of names #3313
Conversation
@@ -121036,6 +121036,7 @@ INSERT INTERFACES HERE | |||
James Perrett, | |||
James Robinson, | |||
Jamie Lokier, | |||
Jan Kühle, <!-- frigus02 on GitHub --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excuse me, maybe its rude to ask, but is Kühle is really your last name or there are two mistakes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok to ask. Kühle is my last name. You can also see it on my GitHub profile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh Im noob. Never thought that this ü
would be transpiled to ü. Thanks for your contribution though
I think having just the ID is fine. If not for the current confusion in the example one probably wouldn’t have mistaken one for the other. |
I was mainly thinking about the I don't mind changing the example to only IDs, though. Should I convert the |
The first example of the output element incorrectly referenced input elements in the "for" attribute by their names. This changes the example to reference input elements by their ids instead (whatwg#3312).
Sorry for the delay on getting back to you here. I think it's totally fine to use any style here: ids + names, ids only with global variable access, ids only with getElementById... The style of examples in the spec is varied, on purpose, to illustrate all the different ways you can write code. So, I think in the end, the question is what you'd prefer, @frigus02 :). And in your OP you said you preferred separate, so let's do that. |
Well, OK, I see after writing that that you switched to only ids. So, uh, just let me know if you want to merge it as-is, or if you want to revert to separate and I'll merge that. Either way! |
Hey @domenic. Don't worry about the delay. I didn't expect prompt feedback during the holidays. :-) You can merge it as as, using only ids. That's fine for me. |
Fixes #3312
The first example of the output element incorrectly referenced input elements in the
for
attribute by their names:I added IDs to the input elements and used them in the
for
attribute. The example looks like this now:Another option would be to only use IDs:
Personally I prefer the first example with separate names and IDs, though.
Please let me know if anything is missing or if this fix is wrong entirely.
/acknowledgements.html ( diff )
/form-elements.html ( diff )