Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: define arc() and ellipse() in terms of shared steps #3348

Merged
merged 2 commits into from
Jan 12, 2018
Merged

Editorial: define arc() and ellipse() in terms of shared steps #3348

merged 2 commits into from
Jan 12, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 12, 2018 •
edited by pr-preview bot
Loading

@annevk
Copy link
Member Author

annevk commented Jan 12, 2018

The main reason this probably doesn't work is because I used "this" and IDL hasn't defined "this" yet. It's rather unclear what else would have made sense here.

@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Jan 12, 2018
domenic
domenic approved these changes Jan 12, 2018
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is enough of an improvement to merge despite IDL's lack of this. You could do "this CanvasPath object" if you wanted to align with some other places in the spec, although I admit that's unsatisfying for mixins.

@annevk annevk merged commit af11308 into master Jan 12, 2018
@annevk annevk deleted the annevk/arc-ellipse branch January 12, 2018 17:32
@annevk annevk removed the do not merge yet Pull request must not be merged per rationale in comment label Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: canvas
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annevk @domenic