Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve creation of 2D and ImageBitmap rendering contexts #3382

Merged
merged 1 commit into from Jan 23, 2018
Merged

Improve creation of 2D and ImageBitmap rendering contexts #3382

merged 1 commit into from Jan 23, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 22, 2018 •
edited by pr-preview bot

The former used "let" to change something and the latter used an undefined context variable to define various things.

/canvas.html ( diff )

@annevk
Improve creation of 2D and ImageBitmap rendering contexts
cb7d768 
The former used "let" to change something and the latter used an undefined context variable to define various things.
@annevk annevk added clarification Standard could be clearer topic: canvas labels Jan 22, 2018
@annevk annevk requested a review from junov January 22, 2018 14:56
junov
junov approved these changes Jan 22, 2018
View reviewed changes
Copy link
Member

@junov junov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@junov
Copy link
Member

junov commented Jan 22, 2018

This is a lot more pleasant to read. Thanks.

@annevk annevk merged commit ad4ddd8 into master Jan 23, 2018
@annevk annevk deleted the annevk/canvas-rendering-context-creation branch January 23, 2018 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junov junov junov approved these changes

Assignees
No one assigned
Labels
clarification Standard could be clearer topic: canvas
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annevk @junov