Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the title attribute with implementations #3435

Merged
merged 1 commit into from Jan 31, 2018
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 31, 2018

This also makes the section conform to the 100 columns formatting requirement.

Test: web-platform-tests/wpt#9306.

Fixes #2743.


/dom.html ( diff )

This also makes the section conform to the 100 columns formatting requirement.

Test: web-platform-tests/wpt#9306.

Fixes #2743.
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it almost feels like a pointless algorithm now, basically codifying some kind of very rudimentary hit-testing.

@annevk
Copy link
Member Author

annevk commented Jan 31, 2018

At least it's defined, unlike hit testing! Perhaps some of the parent-traversal algorithms could be combined, but that can be future cleanup.

@annevk annevk merged commit 2102913 into master Jan 31, 2018
@annevk annevk deleted the annevk/title-attribute branch January 31, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants