Fix content attribute links for the meter element #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Feb 18, 2018
source
Outdated
| string.</p> | ||
|
|
||
| <p>The <dfn><code data-x="dom-meter-min">min</code></dfn> IDL attribute, on getting, must return | ||
| the <span data-x="concept-meter-minimum">minimum value</span>. On setting, the given value must be | ||
| converted to the <span>best representation of the number as a floating-point number</span> and | ||
| then the <code data-x="dom-meter-min">min</code> content attribute must be set to that string.</p> | ||
| then the <code data-x="attr-meter-min">min</code> content attribute must be set to that string.</p> |
There was a problem hiding this comment.
Unfortunately the additional character makes this >100 columns. You'll need to break before "string.</p>"
There was a problem hiding this comment.
https://output.jsbin.com/maferi can help automate this process.
There was a problem hiding this comment.
Should be fixed now.
source
Outdated
|
|
||
| <p>The <dfn><code data-x="dom-meter-max">max</code></dfn> IDL attribute, on getting, must return | ||
| the <span data-x="concept-meter-maximum">maximum value</span>. On setting, the given value must be | ||
| converted to the <span>best representation of the number as a floating-point number</span> and | ||
| then the <code data-x="dom-meter-max">max</code> content attribute must be set to that string.</p> | ||
| then the <code data-x="attr-meter-max">max</code> content attribute must be set to that string.</p> |
source
Outdated
|
|
||
| <p>The <dfn><code data-x="dom-meter-low">low</code></dfn> IDL attribute, on getting, must return | ||
| the <span data-x="concept-meter-low">low boundary</span>. On setting, the given value must be | ||
| converted to the <span>best representation of the number as a floating-point number</span> and | ||
| then the <code data-x="dom-meter-low">low</code> content attribute must be set to that string.</p> | ||
| then the <code data-x="attr-meter-low">low</code> content attribute must be set to that string.</p> |
source
Outdated
| string.</p> | ||
|
|
||
| <p>The <dfn><code data-x="dom-meter-optimum">optimum</code></dfn> IDL attribute, on getting, must | ||
| return the <span data-x="concept-meter-optimum">optimum value</span>. On setting, the given value | ||
| must be converted to the <span>best representation of the number as a floating-point number</span> | ||
| and then the <code data-x="dom-meter-optimum">optimum</code> content attribute must be set to that | ||
| and then the <code data-x="attr-meter-optimum">optimum</code> content attribute must be set to that |
annevk
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #3356. The fix was trivial and I didn't want to leave the issue there.
/form-elements.html ( diff )