Editorial: cleanup activeElement #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct usage of let/set and stop referring to it as a method.
domenic
approved these changes
Feb 27, 2018
source
Outdated
| @@ -73500,36 +73500,32 @@ END:VCARD</pre> | |||
| <code>Document</code> objects must return the value returned by the following steps:</p> | |||
There was a problem hiding this comment.
Maybe uniformize the prelude too? I think these days we're using "must, on getting, run these steps:". (Well, OK, searching for "on getting", we're not very uniform at all. But something like that...)
There was a problem hiding this comment.
I thought it was "The activeElement attribute's getter, when invoked, must run these steps:"...
source
Outdated
|
|
||
| <li><p>If <var>candidate</var> is a <span>focusable area</span>, let <var>candidate</var> be <var>candidate</var>'s <span>DOM anchor</span>.</p></li> | ||
| <li><p>If <var>candidate</var> is a <span>focusable area</span>, then set <var>candidate</var> to | ||
| <var>candidate</var>'s <span>DOM anchor</span>.</p></li> | ||
|
|
||
| <li> |
There was a problem hiding this comment.
This may be cleaner as a set of three nested steps with "If candidate is a Document object:" as the parent step.
|
Markup error causing build failure at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct usage of let/set and stop referring to it as a method.
/browsers.html ( diff )
/interaction.html ( diff )