Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate a new document.open() #3651

Closed
wants to merge 2 commits into from
Closed

Investigate a new document.open() #3651

wants to merge 2 commits into from

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 27, 2018 •
edited by pr-preview bot
Loading

@annevk
Copy link
Member Author

annevk commented Apr 27, 2018 •
edited
Loading

TODO:

  • Investigate if IDL can be simplified
  • Write tests
  • Compare new algorithm to Chromium and WebKit code
  • This makes it so that each document always has a single global. Investigate if we can simplify prose therefore. I think it means we can just use the document's relevant global object throughout.
  • Look at other callers of InitializeHostDefinedRealm and see if they can be simplified.

@annevk annevk force-pushed the annevk/redo-document-open branch from 1c34e3e to 40c3917 Compare May 2, 2018 09:58
annevk added a commit to web-platform-tests/wpt that referenced this pull request May 2, 2018
@annevk
HTML: document.open() and the unload event
38100e2 
For whatwg/html#3651.
@annevk annevk mentioned this pull request May 2, 2018
Merged
annevk added a commit to web-platform-tests/wpt that referenced this pull request May 2, 2018
@annevk
HTML: document.open() and the beforeunload event
22e61d3 
For whatwg/html#3651.
@annevk annevk mentioned this pull request May 2, 2018
Merged
@annevk annevk force-pushed the annevk/redo-document-open branch from 40c3917 to fc36e7d Compare May 3, 2018 07:30
@annevk
Investigate a new document.open()
15f80d1 
For #1698, #3564, ... Needs many tests.
@annevk annevk force-pushed the annevk/redo-document-open branch from fc36e7d to 15f80d1 Compare May 3, 2018 07:33
annevk added a commit to web-platform-tests/wpt that referenced this pull request May 3, 2018
@annevk
HTML: document.open() and global variables
3b06a0c 
For whatwg/html#3651.
@annevk annevk mentioned this pull request May 3, 2018
Merged
annevk added a commit to web-platform-tests/wpt that referenced this pull request May 3, 2018
@annevk
HTML: document.write() and reloading
dc776bb 
For whatwg/html#3651 or possibly a standalone patch.

It seems that Firefox only supports the reload override flag for about:blank resources. Edge always supports it. Safari overrides the URL and therefore ends up in a loop. Chrome doesn't support it, which seems most desirable as it's a rather hairy feature.
@annevk annevk mentioned this pull request May 3, 2018
Open
annevk added a commit to web-platform-tests/wpt that referenced this pull request May 3, 2018
@annevk
HTML: document.open() and document's URL
2c41c8a 
For whatwg/html#3651.
@annevk annevk mentioned this pull request May 3, 2018
Merged
annevk added a commit to web-platform-tests/wpt that referenced this pull request May 3, 2018
@annevk
HTML: document.open() and tasks
4646a3b 
For whatwg/html#3651.
@annevk annevk mentioned this pull request May 3, 2018
Merged
@annevk
Copy link
Member Author

annevk commented May 4, 2018

I don't understand how #1018 came about. I cannot get any browser to fire the unload event when invoking document.open(). Not when the document is still loading and not when it's finished loading. (If I had to guess bz did not consider that and nobody tested it.)

@TimothyGu TimothyGu mentioned this pull request Jul 12, 2018
Closed
19 tasks
TimothyGu pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 13, 2018
@annevk @TimothyGu
HTML: document.open() and tasks
7f392b3 
For whatwg/html#3651.
TimothyGu pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 1, 2018
@annevk @TimothyGu
HTML: document.open() and the unload event
fdc4468 
For whatwg/html#3651.
TimothyGu pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 2, 2018
@annevk @TimothyGu
HTML: document.open() and the beforeunload event
10015a5 
For whatwg/html#3651.
TimothyGu pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 2, 2018
@annevk @TimothyGu
HTML: document.open() and global variables
1ba693f 
For whatwg/html#3651.
TimothyGu added a commit to TimothyGu/html that referenced this pull request Aug 14, 2018
@TimothyGu @annevk
Remove document.open() realm creation
7234c89 
Based on the work by Anne van Kesteren in whatwg#3651, but without the parts
concerning the session history. Changes to that area will come later
(see whatwg#3818).

Tests: web-platform-tests/wpt#10773
Tests: web-platform-tests/wpt#10778
Tests: web-platform-tests/wpt#10789
Tests: web-platform-tests/wpt#10815
Tests: web-platform-tests/wpt#10818

Fixes whatwg#1698.
Fixes whatwg#3286.
Fixes whatwg#3306.
Closes whatwg#3665.

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
TimothyGu added a commit to TimothyGu/html that referenced this pull request Aug 14, 2018
@TimothyGu @annevk
Remove document.open() realm creation
091ac08 
Based on the work by Anne van Kesteren in whatwg#3651, but without the parts
concerning the session history. Changes to that area will come later
(see whatwg#3818).

Tests: web-platform-tests/wpt#10773
Tests: web-platform-tests/wpt#10778
Tests: web-platform-tests/wpt#10815
Tests: web-platform-tests/wpt#10818

Fixes whatwg#1698.
Fixes whatwg#3286.
Fixes whatwg#3306.
Closes whatwg#3665.

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
@TimothyGu TimothyGu mentioned this pull request Aug 14, 2018
Merged
TimothyGu pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 14, 2018
@annevk @TimothyGu
HTML: document.open() and the beforeunload event
e0efb9c 
For whatwg/html#3651.
TimothyGu pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 15, 2018
@annevk @TimothyGu
HTML: document.open() and global variables
d05bb11 
For whatwg/html#3651.
domenic pushed a commit that referenced this pull request Aug 16, 2018
@TimothyGu @domenic
document.open() simplifications, part 1
6f769b8 
In particular, removes the realm creation, document unloading, and tasks
removal steps.

Based on the work by Anne van Kesteren in #3651, but without the parts
concerning the session history. Changes to that area will come later
(see #3818).

These changes allow us to remove several auxiliary concepts that only
existed to support document.open():

- The recycle parameter to the "unload a Document" algorithm
- The window parameter to the "set the active document" algorithm

Tests: web-platform-tests/wpt#10773
Tests: web-platform-tests/wpt#10778
Tests: web-platform-tests/wpt#10815
Tests: web-platform-tests/wpt#10818

Fixes #1698.
Fixes #3286.
Fixes #3306.
Closes #3665.
TimothyGu pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 17, 2018
@annevk @TimothyGu
HTML: document.open() and tasks
4bb3eea 
For whatwg/html#3651.
TimothyGu pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 20, 2018
@annevk @TimothyGu
HTML: document.open() and tasks
8bc21f7 
For whatwg/html#3651.
TimothyGu pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 20, 2018
@annevk @TimothyGu
HTML: document.open() and tasks
1680ac5 
For whatwg/html#3651.
@TimothyGu TimothyGu mentioned this pull request Aug 28, 2018
Merged
TimothyGu added a commit to TimothyGu/html that referenced this pull request Sep 4, 2018
@TimothyGu
document.open(): only abort when there is a navigation
90dffec 
This implements the "ideal 2" plan in whatwg#3651, which is found to be
compatible with the existing Chrome test suite.

Closes whatwg#3651.
Fixes whatwg#3975.

Tests: web-platform-tests/wpt#10789
@TimothyGu TimothyGu mentioned this pull request Sep 4, 2018
Merged
@domenic domenic closed this in #3999 Sep 6, 2018
domenic pushed a commit that referenced this pull request Sep 6, 2018
@TimothyGu @domenic
document.open(): only abort when there is a navigation
1ca520a 
This implements the "ideal 2" plan in #3975, which was found to be
compatible with the existing Chrome test suite while being reasonably
straightforward.

Closes #3651.
Fixes #3975.

Tests: web-platform-tests/wpt#10789
@annevk annevk deleted the annevk/redo-document-open branch January 25, 2019 10:11
mustaqahmed pushed a commit to mustaqahmed/html that referenced this pull request Feb 15, 2019
@TimothyGu @mustaqahmed
document.open() simplifications, part 1
d13d93e 
In particular, removes the realm creation, document unloading, and tasks
removal steps.

Based on the work by Anne van Kesteren in whatwg#3651, but without the parts
concerning the session history. Changes to that area will come later
(see whatwg#3818).

These changes allow us to remove several auxiliary concepts that only
existed to support document.open():

- The recycle parameter to the "unload a Document" algorithm
- The window parameter to the "set the active document" algorithm

Tests: web-platform-tests/wpt#10773
Tests: web-platform-tests/wpt#10778
Tests: web-platform-tests/wpt#10815
Tests: web-platform-tests/wpt#10818

Fixes whatwg#1698.
Fixes whatwg#3286.
Fixes whatwg#3306.
Closes whatwg#3665.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this pull request Feb 15, 2019
@TimothyGu @mustaqahmed
document.open(): only abort when there is a navigation
c405145 
This implements the "ideal 2" plan in whatwg#3975, which was found to be
compatible with the existing Chrome test suite while being reasonably
straightforward.

Closes whatwg#3651.
Fixes whatwg#3975.

Tests: web-platform-tests/wpt#10789
mustaqahmed pushed a commit to mustaqahmed/html that referenced this pull request Feb 15, 2019
@TimothyGu @mustaqahmed
document.open() simplifications, part 1
29c6fee 
In particular, removes the realm creation, document unloading, and tasks
removal steps.

Based on the work by Anne van Kesteren in whatwg#3651, but without the parts
concerning the session history. Changes to that area will come later
(see whatwg#3818).

These changes allow us to remove several auxiliary concepts that only
existed to support document.open():

- The recycle parameter to the "unload a Document" algorithm
- The window parameter to the "set the active document" algorithm

Tests: web-platform-tests/wpt#10773
Tests: web-platform-tests/wpt#10778
Tests: web-platform-tests/wpt#10815
Tests: web-platform-tests/wpt#10818

Fixes whatwg#1698.
Fixes whatwg#3286.
Fixes whatwg#3306.
Closes whatwg#3665.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this pull request Feb 15, 2019
@TimothyGu @mustaqahmed
document.open(): only abort when there is a navigation
d82d154 
This implements the "ideal 2" plan in whatwg#3975, which was found to be
compatible with the existing Chrome test suite while being reasonably
straightforward.

Closes whatwg#3651.
Fixes whatwg#3975.

Tests: web-platform-tests/wpt#10789
@Manishearth Manishearth mentioned this pull request Dec 4, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
normative change topic: document.open()
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annevk @domenic