Use fetch client settings object for fetching submodules #3758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
fetch client settings object
ofinternal module script graph fetching procedure
is used for the top-level module script but not submodules, becausemodule script's settings object
(which ismodule map settings object
ofinternal module script graph fetching procedure
) is passed in Step7 offetch the descendants of a module script
.This PR uses
fetch client settings object
also for submodules, by addingfetch client settings object
argument tofetch the descendants of a module script
, and plumbing it tointernal module script graph fetching procedure
and from callers.Fixes #3757.
/links.html ( diff )
/scripting.html ( diff )
/webappapis.html ( diff )