Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fetch client settings object for fetching submodules #3758

Merged
merged 2 commits into from
Jun 13, 2018

Conversation

hiroshige-g
Copy link
Contributor

@hiroshige-g hiroshige-g commented Jun 12, 2018

Previously, fetch client settings object of internal module script graph fetching procedure is used for the top-level module script but not submodules, because module script's settings object (which is module map settings object of internal module script graph fetching procedure) is passed in Step7 of fetch the descendants of a module script.

This PR uses fetch client settings object also for submodules, by adding fetch client settings object argument to fetch the descendants of a module script, and plumbing it to internal module script graph fetching procedure and from callers.

Fixes #3757.


/links.html ( diff )
/scripting.html ( diff )
/webappapis.html ( diff )

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, thank you!

@domenic domenic merged commit 184be2f into whatwg:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants