Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document.open() simplifications, part 2 #3946

Merged
merged 4 commits into from Aug 23, 2018
Merged

document.open() simplifications, part 2 #3946

merged 4 commits into from Aug 23, 2018

Commits on Aug 23, 2018

  1. Remove overridden reload concept 

    Or: document.open() simplifications, part 1.9.

This behavior is only implemented in Firefox and Edge and has
contributed to developer confusion. See
https://bugzilla.mozilla.org/show_bug.cgi?id=556002.

This is a part of the effort to renovate document.open(). See
whatwg#3818 for context.

Tests: web-platform-tests/wpt#12555
    @TimothyGu
    TimothyGu committed Aug 23, 2018
    Copy the full SHA
    38efcee View commit details
    Browse the repository at this point in the history

  2. Editorial: Factor out history.push/replaceState() steps 

    The resultant URL and history state update steps will be used in
document.open().
    @TimothyGu
    TimothyGu committed Aug 23, 2018
    Copy the full SHA
    51f52de View commit details
    Browse the repository at this point in the history

  3. document.open() simplifications, part 2 

    The current behavior of adding a new entry to the session history is
removed, with the "replace" parameter behavior made the only option. To
fix whatwg#3885, we now reuse history.replaceState()'s history model, which
keeps the document's URL and the history entry URL in sync.

At the same time, we restrict the history state update (including
setting the document's URL) to be only run with fully active documents.
Firefox already bails out for non-fully active documents (including
those that are active documents), and it's not expected that there would
be much usage of the URL of non-fully active documents anyway.

This allows us to additionally remove the seldom implemented "replace"
parameter in document.open(), whose behavior is now the default
(aligning with with Chrome and Safari). The IDL is modified accordingly.

Tests: web-platform-tests/wpt#12555
Tests: web-platform-tests/wpt#12634
Tests: web-platform-tests/wpt#12636
Tests: web-platform-tests/wpt#12650

Fixes whatwg#3564.
Fixes whatwg#3885.
    @TimothyGu
    TimothyGu committed Aug 23, 2018
    Copy the full SHA
    b6e1c2b View commit details
    Browse the repository at this point in the history

  4. Editorial: Remove parameters from document.open() references 

    This effectively reverts parts of
8f2816a.
    @TimothyGu
    TimothyGu committed Aug 23, 2018
    Copy the full SHA
    2e193aa View commit details
    Browse the repository at this point in the history