Tweak how accesskey on legend works #3987

zcorpan · 2018-09-03T09:02:10Z

If the parent is a fieldset, then accesskey on legend delegates to the first appropriate element of the fieldset (but not a label or legend).

Fixes #3950.

Tests:
web-platform-tests/wpt#12800
web-platform-tests/wpt#12801

/interactive-elements.html ( diff )

Fixes #3950. Tests: TODO

See whatwg/html#3987

zcorpan · 2018-09-03T11:53:16Z

Actually, Edge/Chrome/Safari don't check if the legend is itself focusable. I'll go with the majority.

zcorpan · 2018-09-03T13:09:09Z

Bugs:
https://bugzilla.mozilla.org/show_bug.cgi?id=1488185
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/18881474/

Safari and Chrome pass the accesskey tests.

annevk

A quick description of the intended change would help with review.

annevk · 2018-09-05T09:29:02Z

source

-  element but that <span data-x="concept-command">defines a command</span>, itself <span
-  data-x="concept-command">defines a command</span>.</p>
+  <p>A <code>legend</code> element that has an <span>assigned access key</span> and is a child of
+  a <code>fieldset</code> element that has a descendant that element and is neither a


This sentence doesn't work.

zcorpan · 2018-09-05T11:47:40Z

Fixed the grammar, and added a description in the OP.

annevk · 2018-09-05T12:39:44Z

source

+  <p>A <code>legend</code> element that has an <span>assigned access key</span> and is a child of
+  a <code>fieldset</code> element that has a descendant that is neither a <code>label</code>
+  element nor a <code>legend</code> element but that <span data-x="concept-command">defines a
+  command</span>, itself <span data-x="concept-command">defines a command</span>.</p>


So multiple legend element children would be multiple commands?

Also, should there be a comma before "but"?

They would, yes. Works in Safari/Chrome/Firefox/Edge.

annevk · 2018-09-05T12:39:55Z

source

-  a descendant of the <code>legend</code> element and is neither a <code>label</code> nor a
-  <code>legend</code> element.</p>
+  <code>legend</code> element that <span data-x="concept-command">defines a command</span> but is
+  neither a <code>label</code> nor a <code>legend</code> element.</p>


Comma before "but"?

This sentence also doesn't quite seem to work. Is it the first element command that is neither a label or legend element or is it the first element command, but only if it's not a label or legend element?

annevk

Sorry, I'm still confused. If @domenic is okay with this though I guess it can be merged...

annevk · 2018-09-06T07:55:05Z

source

+  <p>A <code>legend</code> element that has an <span>assigned access key</span> and is a child of
+  a <code>fieldset</code> element that has a descendant that is neither a <code>label</code>
+  element nor a <code>legend</code> element, but that <span data-x="concept-command">defines a
+  command</span>, itself <span data-x="concept-command">defines a command</span>.</p>


I still struggle with this. Perhaps make this a list:

A legend element defines a command if all of the following are true:

It has an assigned access key

It's a child of a fieldset element

Its parent has at least one descendant element that defines a command and is neither a label nor legend element.

annevk · 2018-09-06T07:56:38Z

source

-  a descendant of the <code>legend</code> element and is neither a <code>label</code> nor a
-  <code>legend</code> element.</p>
+  <code>legend</code> element that is neither a <code>label</code> nor a <code>legend</code>
+  element, that <span data-x="concept-command">defines a command</span>.</p>


Same here, this still seems ambiguous to me.

zcorpan · 2018-09-06T12:37:15Z

PTAL

annevk

Looks good modulo 1 nit. Given the many turnarounds (apologies for not being clear enough to avoid that) I'd like @domenic to do a final review in case I'm missing something.

annevk · 2018-09-06T13:19:11Z

source

+   <li><p>It has an <span>assigned access key</span>.</p></li>
+   <li><p>It is a child of a <code>fieldset</code> element.</p></li>
+   <li><p>Its parent has a descendant that <span data-x="concept-command">defines a command</span>
+   but is neither a <code>label</code> element nor a <code>legend</code> element.</p></li>


and is neither?

domenic

Sorry to drag this out, but I do think there's some real potential for improvement here, which I hope you're up for.

domenic · 2018-09-06T20:16:36Z

source

+   <li><p>It has an <span>assigned access key</span>.</p></li>
+   <li><p>It is a child of a <code>fieldset</code> element.</p></li>
+   <li><p>Its parent has a descendant that <span data-x="concept-command">defines a command</span>
+   and is neither a <code>label</code> element nor a <code>legend</code> element.</p></li>


"and is" -> "that is", if I understand correctly??

domenic · 2018-09-06T20:16:53Z

source

+   <li><p>It is a child of a <code>fieldset</code> element.</p></li>
+   <li><p>Its parent has a descendant that <span data-x="concept-command">defines a command</span>
+   and is neither a <code>label</code> element nor a <code>legend</code> element.</p></li>
+  </ul>


This would really benefit from an example or two

domenic · 2018-09-06T20:20:08Z

source

-  <code>legend</code> element.</p>
+  facets of the first element in <span>tree order</span> that matches all of the following:</p>
+
+  <ul>


The duplication here is unfortunate. I'd suggest modifying the previous

Its parent has a descendant that defines a command that is neither a label element nor a legend element

to

Its parent has a descendant that defines a command and is neither a label element nor a legend element. This descendant, if it exists, is the something something.

Then you can say "are the same as the respective facets of the something something."

zcorpan · 2018-09-06T20:56:10Z

@domenic PTAL

domenic

LGTM with nit, nice turnaround time :D

domenic · 2018-09-06T21:07:43Z

source

-  <code>legend</code> element and is neither a <code>label</code> element nor a <code>legend</code>
-  element but that <span data-x="concept-command">defines a command</span>, itself <span
-  data-x="concept-command">defines a command</span>.</p>
+  <p>A <code>legend</code> element <span data-x="concept-command">defines a command</span> if all of the following are true:</p>


See whatwg/html#3987

Automatic update from web-platform-testsHTML: test accesskey for legend See whatwg/html#3987 -- wpt-commits: de955843cde5540bfc63015490630beeb1f19f89 wpt-pr: 12800

Automatic update from web-platform-testsHTML: test accesskey for legend See whatwg/html#3987 -- wpt-commits: de955843cde5540bfc63015490630beeb1f19f89 wpt-pr: 12800 UltraBlame original commit: 0ede957914c48b05a03cf9f754cbd9dfc4cad057

zcorpan added 2 commits September 3, 2018 10:40

Editorial: Consistently say 'Access Key'

19fc441

Tweak how accesskey on legend works

b240785

Fixes #3950. Tests: TODO

zcorpan added accessibility Affects accessibility topic: fieldset needs tests Moving the issue forward requires someone to write tests labels Sep 3, 2018

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Sep 3, 2018

HTML: test accesskey for legend

4d95f9d

See whatwg/html#3987

zcorpan mentioned this pull request Sep 3, 2018

HTML: test accesskey for legend web-platform-tests/wpt#12800

Merged

zcorpan removed the needs tests Moving the issue forward requires someone to write tests label Sep 3, 2018

zcorpan added the do not merge yet Pull request must not be merged per rationale in comment label Sep 3, 2018

Don't special-case focusable legend, like Edge/Chrome/Safari

88141ed

zcorpan removed the do not merge yet Pull request must not be merged per rationale in comment label Sep 3, 2018

annevk reviewed Sep 5, 2018

View reviewed changes

Fix grammar

a7eab2c

annevk reviewed Sep 5, 2018

View reviewed changes

Fix wording

32edc80

annevk reviewed Sep 6, 2018

View reviewed changes

Use lists to make it less ambiguous

782dedc

annevk approved these changes Sep 6, 2018

View reviewed changes

and

9c1e740

zcorpan requested a review from domenic September 6, 2018 14:21

domenic reviewed Sep 6, 2018

View reviewed changes

zcorpan added 2 commits September 6, 2018 22:42

Address domenic's comments

964c8e8

Add an example

9fdb4a0

domenic approved these changes Sep 6, 2018

View reviewed changes

Source formatting nits

3495b6e

zcorpan merged commit aa374be into master Sep 6, 2018

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Sep 7, 2018

HTML: test accesskey for legend

de95584

See whatwg/html#3987

annevk deleted the zcorpan/legend-accesskey branch September 7, 2018 08:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tweak how accesskey on legend works #3987

Tweak how accesskey on legend works #3987

zcorpan commented Sep 3, 2018 •

edited by pr-preview bot

Loading

zcorpan commented Sep 3, 2018

zcorpan commented Sep 3, 2018

annevk left a comment

annevk Sep 5, 2018

zcorpan commented Sep 5, 2018

annevk Sep 5, 2018

zcorpan Sep 5, 2018

annevk Sep 5, 2018

annevk Sep 5, 2018

zcorpan Sep 5, 2018

annevk left a comment

annevk Sep 6, 2018

annevk Sep 6, 2018

zcorpan commented Sep 6, 2018

annevk left a comment

annevk Sep 6, 2018

domenic left a comment

domenic Sep 6, 2018

domenic Sep 6, 2018

domenic Sep 6, 2018

zcorpan commented Sep 6, 2018

domenic left a comment

domenic Sep 6, 2018

Tweak how accesskey on legend works #3987

Tweak how accesskey on legend works #3987

Conversation

zcorpan commented Sep 3, 2018 • edited by pr-preview bot Loading

zcorpan commented Sep 3, 2018

zcorpan commented Sep 3, 2018

annevk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zcorpan commented Sep 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annevk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zcorpan commented Sep 6, 2018

annevk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

domenic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zcorpan commented Sep 6, 2018

domenic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zcorpan commented Sep 3, 2018 •

edited by pr-preview bot

Loading