Ground custom elements in agents #4204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
the
do not merge yet
|
Pending ongoing disagreements in #4198 and whatwg/dom#717, so tagging "do not merge yet". |
annevk
force-pushed
the
annevk/ce-agents
branch
from
ec8864a
to
222ed14
Compare
|
@domenic I think we reached agreement, can you take a look at the PR? |
domenic
removed
the
do not merge yet
domenic
approved these changes
Jan 14, 2019
annevk
added a commit
that referenced
this pull request
Jan 15, 2019
These would improve whatwg/dom#717 and #4204.
annevk
added a commit
that referenced
this pull request
Jan 15, 2019
These would improve whatwg/dom#717 and #4204.
annevk
force-pushed
the
annevk/ce-agents
branch
from
222ed14
to
567e543
Compare
|
This could probably use another look over to be safe. |
domenic
requested changes
Jan 16, 2019
| <li><p>Let <var>queue</var> be the result of popping the <span>current element queue</span> | ||
| from the <span>custom element reactions stack</span>. (This will be the same <span>element | ||
| <li><p>Let <var>queue</var> be the result of popping <var>document</var>'s <span>relevant | ||
| agent</span>'s <span>current element queue</span>. (This will be the same <span>element |
There was a problem hiding this comment.
You don't pop the queue. You pop from the stack; the result is === the current queue (at least, the current queue before popping). I think just omit mention of the current queue from here, and use "popping from" like above.
domenic
added
the
topic: custom elements
domenic
approved these changes
Jan 16, 2019
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
These would improve whatwg/dom#717 and whatwg#4204.
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
These would improve whatwg/dom#717 and whatwg#4204.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "unit of related similar-origin browsing contexts" concept is inaccurate.
Helps with #4198.
/custom-elements.html ( diff )
/parsing.html ( diff )