Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add audio crossorigin attr to list of common attrs #4221

Merged
merged 2 commits into from Dec 11, 2018
Merged

Add audio crossorigin attr to list of common attrs #4221

merged 2 commits into from Dec 11, 2018

Conversation

Garee
Copy link
Contributor

@Garee Garee commented Dec 2, 2018 •
edited

'crossorigin' is an attribute that is common to all media elements. The
media element has this attribute, but it is missing from the list of attributes
that are identified as being common. This change adds it to the list for clarity.

Fixes #4159

@Garee
Add audio crossorigin attr to list of common attrs
a9654e6 
'crossorigin' is an attribute that is common to all media elements. The <audio>
media element has this attribute, but it is missing from the list of attributes
that are identified as being common. This change adds it to the list for clarity.
domenic
domenic requested changes Dec 10, 2018
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the same sentence in the <video> section?

@Garee
Add video crossorigin attr to list of common attrs
fde3886 
'crossorigin' is an attribute that is common to all media elements. The <video>
media element has this attribute, but it is missing from the list of attributes
that are identified as being common. This change adds it to the list for clarity.
@Garee
Copy link
Contributor Author

Garee commented Dec 10, 2018

@domenic Yes, I have updated the <video> section.

domenic
domenic approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you, and congrats on your first HTML contribution!

@domenic domenic merged commit edc1e95 into whatwg:master Dec 11, 2018
@domenic domenic added clarification Standard could be clearer topic: media labels Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
clarification Standard could be clearer topic: media
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Garee @sideshowbarker @domenic