Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the s flag for matching ol/li's type attribute #4233

Merged
merged 2 commits into from Dec 18, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 11, 2018

@annevk
Copy link
Member Author

annevk commented Dec 11, 2018

There's an intent to ship against Firefox for implementing the s flag, so I suspect it's fine to use now.

@NOVALISTIC could you please check how you're acknowledged? Thanks again for raising this, had a bit of an impact. 😊

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we can go ahead and merge this, despite it only having one implementer committed to the underlying s feature, because this is effectively a non-normative change to the HTML standard, just rephrasing things using different mechanisms. (At least, I assume this change is not observable compared to the old prose-based mechanism.)

@annevk
Copy link
Member Author

annevk commented Dec 12, 2018

Correct, I'll give @NOVALISTIC some more time before merging though.

@domenic
Copy link
Member

domenic commented Dec 18, 2018

Will merge, but @NOVALISTIC, please let us know if you'd prefer a different acknowledgment!

@domenic domenic merged commit 31334d7 into master Dec 18, 2018
@domenic domenic deleted the annevk/selector-matching branch December 18, 2018 22:33
@NOVALISTIC
Copy link

Huh, for some reason I was never notified of this.

That looks good, thanks for the acknowledgement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants