Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XML loading's namespace-based dispatching #4384

Merged
merged 1 commit into from Feb 26, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 21, 2019

It's not implemented and complicates navigation.

Closes #2656.


/browsing-the-web.html ( diff )

It's not implemented and complicates navigation.

Closes #2656.
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like confirmation that nobody implements this first.

@domenic domenic added removal/deprecation Removing or deprecating a feature topic: navigation do not merge yet Pull request must not be merged per rationale in comment and removed do not merge yet Pull request must not be merged per rationale in comment labels Feb 21, 2019
@domenic
Copy link
Member

domenic commented Feb 26, 2019

I am content that enough time has gone by for folks to respond in #2656 that we can merge this. We can always revert if we got something horribly wrong.

@domenic domenic merged commit 38cac77 into master Feb 26, 2019
@domenic domenic deleted the annevk/namespace-based-dispatching branch February 26, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removal/deprecation Removing or deprecating a feature topic: navigation
Development

Successfully merging this pull request may close these issues.

None yet

2 participants