Stop using White_Space #4860
Merged
Stop using White_Space #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For semantics of something being empty (table cells in this case) we should only consider ASCII whitespace, as we do elsewhere. Fixes #4854.
sideshowbarker
approved these changes
Aug 23, 2019
sideshowbarker
approved these changes
Aug 23, 2019
|
I guess I'll leave this open for a bit to let the discussion settle. Appreciate the quick reviews though! |
annevk
added
the
do not merge yet
domenic
approved these changes
Aug 23, 2019
|
lgtm. It's pretty annoying that CSS's handling of white space isn't somehow consistent with HTML's, but implementations do weird things with form feeds and carriage returns. :/ I'm not really sure what's a good way to reconcile that. |
annevk
removed
the
do not merge yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For semantics of something being empty (table cells in this case) we should only consider ASCII whitespace, as we do elsewhere.
Fixes #4854.
/acknowledgements.html ( diff )
/common-microsyntaxes.html ( diff )
/tables.html ( diff )