Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export dfns for Page Visibility spec #4892

Closed
wants to merge 1 commit into from

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Sep 8, 2019

Non-normative changes... just exports.


/browsing-the-web.html ( diff )
/history.html ( diff )

@domenic
Copy link
Member

domenic commented Sep 8, 2019

I'm not sure what to do here, as the usages of these terms are by a spec which pretty clearly monkey-patches HTML in bad ways. For example, the usage of "session history entry" is in an algorithm that reads "When the user agent determines that the visibility of the Document of the top-level browsing context has changed ... If traversing to a session history entry ...". The correct thing to do here is to actually update HTML's session history traversal algorithm, so that implementers working on that algorithm can see how it works.

That is to say, if the specifications were properly layered, "session history entry" would not be a concept that is referred to by specs outside of HTML. So I don't think we should export it, and encourage further abuse of this sort.

The other two "change steps" though are definitely meant to be exported, so that portion of the patch makes sense. Although I note that "session history document visibility change steps" isn't actually used by the Page Visibility spec, and the way in which it uses "unloading document visibility change steps" is incorrect. (It doesn't define the steps, it just references them during its monkey-patch algorithm.)

@marcoscaceres
Copy link
Member Author

Can I just say that... I love this! This is exactly the kinds of bugs that I'm hoping we will find as we move folks to be entirely dependent on exported definitions from cross references (I know, I'm preaching to the choir - but still, it's exciting!).

I'm not actually involved with the Page Visibility spec, was just doing some cleanup... so will take the above back to the Web Perf WG and file a bug there.

@domenic
Copy link
Member

domenic commented Sep 18, 2019

Let's close this until such a time as Page Visibility is properly layered on to HTML.

@domenic domenic closed this Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants