Change click and contextmenu event types to PointerEvent #5324

NavidZ · 2020-03-02T17:30:42Z

As per change in ui events change click and
contextmenu event types to PointerEvent.

At least two implementers are interested (and none opposed):
- Chrome (@NavidZ) / Edge (@BoCupp-Microsoft)
- Firefox (@smaug----)
Tests are written and can be reviewed and commented upon at:
- Under development. I will add the link as soon as it is landed.
Implementation bugs are filed:
- Chrome: https://crbug.com/989958
- Firefox: …
- Safari: …

/indices.html ( diff )
/infrastructure.html ( diff )
/webappapis.html ( diff )

rniwa · 2020-03-03T07:11:57Z

Are you sure this change is Web compatible? @cdumez

NavidZ · 2020-03-03T15:27:24Z

Are you sure this change is Web compatible?

FYI @BoCupp-Microsoft @smaug----

This was discussed at length in Pointer Events working group. As far as we tested this on Chrome through flags enabling the feature we didn't see any reports from anyone. However, we would like to at least have a wording in the spec and send an intent to ship and enable this by default so we get 100% of traffic on this feature and see whether there is anything out there that might be broken due to this. If anything comes up we need to investigate and see what we can do to mitigate that or even maybe rollback the change.

domenic · 2020-03-03T16:11:16Z

Can you restore the pull request template that was deleted? It contains important information we need to have filled out.

NavidZ · 2020-03-09T15:57:34Z

Can you restore the pull request template that was deleted? It contains important information we need to have filled out.

done.

domenic

This doesn't appear to change any normative text; only the non-normative index. I guess this is just following changes to https://w3c.github.io/uievents/ which says to use PointerEvent for click. (Although it doesn't seem to define contextmenu at all 🙁.)

Is the intention to change https://html.spec.whatwg.org/#fire-a-synthetic-mouse-event as well?

domenic · 2020-03-09T18:00:07Z

source

@@ -3242,6 +3242,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
    <p>The following features are defined in <cite>Pointer Events</cite>: <ref spec=POINTEREVENTS></p>

    <ul class="brief">
+     <li><dfn data-x-href="https://www.w3.org/TR/pointerevents3/#pointerevent-interface"><code>PointerEvent</code></dfn> interface</li>


Can you link to the editor's draft, like the line below?

NavidZ · 2020-03-09T18:10:08Z

This doesn't appear to change any normative text; only the non-normative index. I guess this is just following changes to https://w3c.github.io/uievents/ which says to use PointerEvent for click. (Although it doesn't seem to define contextmenu at all 🙁.)

Yeah. Unfortunately I couldn't find anywhere defining contextmenu event in a normative way.

Is the intention to change https://html.spec.whatwg.org/#fire-a-synthetic-mouse-event as well?

Good point. Although firing that in a PointerEvent manner wouldn't help at much as we would have to fill all the default attributes for that click event but that doesn't hurt to change at as well to be consistent. I'll make sure to also change that in Chromium and measure the impact as whole in terms of backward compatibility.

smaug---- · 2020-03-10T20:32:41Z

(Chrome and Edge counts as one implementation obviously ;) )

domenic

This looks good to me as an editorial PR that just updates HTML to reflect changes already made to UI events.

I'm unsure whether we should merge now so that the two specs are consistent, or wait until there are tests and compat data showing this is possible. I think it would have been ideal if we waited for both specs.

I tend to prefer waiting, even for editorial/alignment changes, so that HTML can serve as a "checkpoint" that helps encourage tests/implementer interest. So for now I'll tag this "do not merge yet".

That also seems like the right call since we may want to update the click() algorithm too, and we don't know yet.

NavidZ · 2020-03-10T21:31:20Z

(Chrome and Edge counts as one implementation obviously ;) )

Fair enough. I guess I should get into the habit of using Chromium instead of Chrome to be more inclusive.

I tend to prefer waiting, even for editorial/alignment changes, so that HTML can serve as a "checkpoint" that helps encourage tests/implementer interest. So for now I'll tag this "do not merge yet".

Sounds good to me.

patrickhlauke · 2020-09-15T07:16:16Z

Just wanted to check if there's been any further discussion/movement on this, as we have a PR on the Pointer Events spec that's currently hanging/waiting. w3c/pointerevents#317

Also, cross-referencing this UI Events PR which has been merged already w3c/uievents#259

annevk · 2020-09-15T10:13:41Z

@patrickhlauke looking at OP it seems this needs tests as well as more browser bugs at least. And per the comments above some demonstration that this is web-compatible would also be good. Has this change shipped somewhere?

patrickhlauke · 2020-09-15T11:20:04Z

@NavidZ @mustaqahmed can probably speak more to that

mustaqahmed · 2020-09-15T14:34:10Z

In Chrome we are currently running a limited trial which seems to suggest the change in web compatible. To get a conclusive evidence, we have a plan to expand the trial to more population in a careful way---we expect to finalize a plan by end of this month.

NavidZ · 2020-09-15T15:27:03Z

In Chrome we are currently running a limited trial which seems to suggest the change in web compatible. To get a conclusive evidence, we have a plan to expand the trial to more population in a careful way---we expect to finalize a plan by end of this month.

@liviutinta @mustaqahmed could you also add a link to the wpt test for this as well as other browser bugs to the issue description.

mustaqahmed · 2020-11-03T19:42:19Z

@liviutinta just landed the following three WPTs in pointerevents/ folder:
pointerevent_auxclick_is_a_pointerevent.html
pointerevent_click_is_a_pointerevent.html
pointerevent_contextmenu_is_a_pointerevent.html

domenic · 2020-11-03T20:23:16Z

Great! I can take care of rebasing.

Have you confirmed that we don't want to change element.click(), and that will continue to use MouseEvent?

mustaqahmed · 2020-11-03T20:36:06Z

I think any "click" event created by the UA would be a PointerEvent, including the one from element.click(). And of course the fired event will be an intanceof MouseEvent as well by event class hierarchy.

We are gradually ramping up our Chrome Beta experiment because we are not seeing any regression. We are expecting to send out an intent to ship soon.

domenic · 2020-11-03T20:37:21Z

Oh, OK. In that case we need more spec and test updates to proceed; this spec PR does not change click(), and the above tests don't seem to test it.

NavidZ · 2020-11-04T14:39:38Z

I think any "click" event created by the UA would be a PointerEvent, including the one from element.click(). And of course the fired event will be an intanceof MouseEvent as well by event class hierarchy.

I might be wrong but I don't remember making that change to change element.click to be PointerEvent as well. You might want to double check and see whether that is also part of the change or not in Chromium.

domenic · 2020-11-06T18:55:00Z

I'll rebase and merge this since click() is being handled separately in #6126.

This only updates the event index. The normative text for firing click is in UI Events, and was changed in w3c/uievents#259. There is no normative text for firing the contextmenu event, sadly.

This is a follow-up to #5324.

NavidZ mentioned this pull request Mar 9, 2020

Change the type of click, auxclick, and contextmenu to PointerEvent w3c/pointerevents#317

Merged

domenic requested changes Mar 9, 2020

View reviewed changes

domenic approved these changes Mar 10, 2020

View reviewed changes

domenic added the do not merge yet Pull request must not be merged per rationale in comment label Mar 10, 2020

This was referenced Nov 5, 2020

HTMLElement.click() fires PointerEvent #6126

Merged

Change click, auxclick, contextmenu to PointerEvent mozilla/standards-positions#455

Closed

Change click and contextmenu event types to PointerEvent

5618050

This only updates the event index. The normative text for firing click is in UI Events, and was changed in w3c/uievents#259. There is no normative text for firing the contextmenu event, sadly.

domenic force-pushed the click-type branch from 722ff61 to 5618050 Compare November 6, 2020 18:59

domenic merged commit 2eae259 into whatwg:master Nov 6, 2020

domenic added topic: events impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation and removed do not merge yet Pull request must not be merged per rationale in comment labels Nov 6, 2020

domenic pushed a commit that referenced this pull request Nov 6, 2020

Change click() to fire a PointerEvent

853bd85

This is a follow-up to #5324.

liviutinta mentioned this pull request Nov 16, 2020

PanelMenu and click event with fractional coordinates grafana/grafana#29138

Closed

danielhjacobs mentioned this pull request Jul 13, 2023

Note contextmenu, click, and auxclick are PointerEvents though Firefox and Safari don't follow the standard mdn/content#27929

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change click and contextmenu event types to PointerEvent #5324

Change click and contextmenu event types to PointerEvent #5324

NavidZ commented Mar 2, 2020 •

edited by pr-preview bot

Loading

rniwa commented Mar 3, 2020

NavidZ commented Mar 3, 2020

domenic commented Mar 3, 2020

NavidZ commented Mar 9, 2020

domenic left a comment

domenic Mar 9, 2020

NavidZ Mar 10, 2020

NavidZ commented Mar 9, 2020

smaug---- commented Mar 10, 2020

domenic left a comment •

edited

Loading

NavidZ commented Mar 10, 2020

patrickhlauke commented Sep 15, 2020

annevk commented Sep 15, 2020

patrickhlauke commented Sep 15, 2020

mustaqahmed commented Sep 15, 2020

NavidZ commented Sep 15, 2020

mustaqahmed commented Nov 3, 2020

domenic commented Nov 3, 2020

mustaqahmed commented Nov 3, 2020

domenic commented Nov 3, 2020

NavidZ commented Nov 4, 2020

domenic commented Nov 6, 2020

Change click and contextmenu event types to PointerEvent #5324

Change click and contextmenu event types to PointerEvent #5324

Conversation

NavidZ commented Mar 2, 2020 • edited by pr-preview bot Loading

rniwa commented Mar 3, 2020

NavidZ commented Mar 3, 2020

domenic commented Mar 3, 2020

NavidZ commented Mar 9, 2020

domenic left a comment

Choose a reason for hiding this comment

domenic Mar 9, 2020

Choose a reason for hiding this comment

NavidZ Mar 10, 2020

Choose a reason for hiding this comment

NavidZ commented Mar 9, 2020

smaug---- commented Mar 10, 2020

domenic left a comment • edited Loading

Choose a reason for hiding this comment

NavidZ commented Mar 10, 2020

patrickhlauke commented Sep 15, 2020

annevk commented Sep 15, 2020

patrickhlauke commented Sep 15, 2020

mustaqahmed commented Sep 15, 2020

NavidZ commented Sep 15, 2020

mustaqahmed commented Nov 3, 2020

domenic commented Nov 3, 2020

mustaqahmed commented Nov 3, 2020

domenic commented Nov 3, 2020

NavidZ commented Nov 4, 2020

domenic commented Nov 6, 2020

NavidZ commented Mar 2, 2020 •

edited by pr-preview bot

Loading

domenic left a comment •

edited

Loading