Add missing sandbox keywords to indices #5406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of recognized keywords for the "sandbox" attribute of iframes as understood by the "parse a sandboxing directive" algorithm had two more values (`allow-downloads` and `allow-top-navigation-by-user-activation`) than the list in the index. This adds those two values to the index.
|
Great call! And yeah, a HTML comment makes sense to me. Any progress on Shape Security/F5 Networks signing the Participant Agreement? |
Ah, not yet. I'll ping someone internally. I forgot WHATWG required it even for non-substantive changes (not for the first time). (Feel free to consider this a detailed bug report and submit a fresh PR fixing it in the mean time, I guess.) |
This was referenced Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of recognized keywords for the "sandbox" attribute of iframes as understood by the "parse a sandboxing directive" algorithm had two more values (
allow-downloadsandallow-top-navigation-by-user-activation) than the list in the index. This adds those two values to the index.The index was presumably overlooked in #2292 and #4293. Perhaps it would be worth adding a comment (either a Note or an HTML comment) to "parse a sandboxing directive"?
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Jan 15, 2021, 8:00 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.