Make all agent allocation imperative #5411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
clarification
domenic
added a commit
to domenic/ServiceWorker
that referenced
this pull request
Mar 27, 2020
domenic
force-pushed
the
imperative-agent-cluster-allocation
branch
from
62f035c
to
6c11764
Compare
domenic
added a commit
to domenic/css-houdini-drafts
that referenced
this pull request
Mar 27, 2020
domenic
added a commit
that referenced
this pull request
Mar 30, 2020
This adds a specific definition for "an agent's event loop", as opposed to "event loop" generally, and uses it where appropriate. In a few cases, this involves moving from "object's event loop" to "object's relevant agent's event loop". Note that for worker agents, event loop creation and association with the agent is explicit. For window agents there is no corresponding text. This can be settled as part of #5411.
|
#5416 should land before this, and then after it does, this PR should be updated to explicitly create event loops and associate them with agents at agent creation time. |
annevk
reviewed
Mar 31, 2020
|
|
||
| <div w-nodev> | ||
|
|
||
| <p>To <dfn>create an agent</dfn>, given a boolean <var>canBlock</var>:</p> |
There was a problem hiding this comment.
I think this is fine, but I do wonder about the relationship with agent clusters. I guess we'll just wait for JavaScript to organize that?
domenic
added a commit
that referenced
this pull request
Mar 31, 2020
This adds a specific definition for "an agent's event loop", as opposed to "event loop" generally, and uses it where appropriate. In a few cases, this involves moving from "object's event loop" to "object's relevant agent's event loop". Note that for worker agents, event loop creation and association with the agent is explicit. For window agents there is no corresponding text. This can be settled as part of #5411.
domenic
added a commit
that referenced
this pull request
Mar 31, 2020
This adds a specific definition for "an agent's event loop", as opposed to "event loop" generally, and uses it where appropriate. In a few cases, this involves moving from "object's event loop" to "object's relevant agent's event loop". Note that for worker agents, event loop creation and association with the agent is explicit. For window agents there is no corresponding text. This can be settled as part of #5411.
Closes #5210. Closes #4339 by removing the explicit phrasing of a parallel execution environment, instead relying on the agent infrastructure. Closes #4988 by reintroducing a definition for "similar-origin window agent", separate from its creation algorithm. Like the definition of all agent types, it is now informal, just stating what globals are contained in the agent. Relocates the site-related definitions to the "Origin" section of the spec, adjacent to the "schemelessly same site" and "same site" definitions. Exposes some of the higher-level concepts here to the dev edition.
domenic
force-pushed
the
imperative-agent-cluster-allocation
branch
from
3924e32
to
fdebd6b
Compare
|
Ready for re-review. Thanks for the suggestions; your version of obtain a worker/worklet agent is much better. |
domenic
added a commit
to domenic/css-houdini-drafts
that referenced
this pull request
Mar 31, 2020
Follows whatwg/html#5411. Also includes a top-level origin, introduced in whatwg/html#4966.
annevk
approved these changes
Mar 31, 2020
| agent">obtaining a dedicated/shared worker agent</span> given <var>outside settings</var> and | ||
| <var>is shared</var>. Run the rest of these steps in that agent.</p> | ||
|
|
||
| <p id="worker-processing-model-top">For the purposes of timing APIs, this is the <dfn |
There was a problem hiding this comment.
I can't really figure out what this is used for; neither the HTML spec itself, nor https://w3c.github.io/hr-time/, references it. So I guessed that it might be best used for something that wanted to link to "when we enter a parallel thread", which now aligns with this step. Otherwise one would just link to "run a worker" directly.
There was a problem hiding this comment.
935599c and https://www.w3.org/Bugs/Public/show_bug.cgi?id=21725 suggest we could remove it.
bfgeek
pushed a commit
to w3c/css-houdini-drafts
that referenced
this pull request
Apr 6, 2020
Follows whatwg/html#5411. Also includes a top-level origin, introduced in whatwg/html#4966.
jakearchibald
added a commit
to w3c/ServiceWorker
that referenced
this pull request
Apr 7, 2020
* Update agent and realm allocation Follows whatwg/html#5411. * Update docs/index.bs * Update docs/index.bs * agent/event loop * Event loop and other ESO fixes Co-authored-by: Jake Archibald <jaffathecake@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5210.
Closes #4339 by removing the explicit phrasing of a parallel execution
environment, instead relying on the agent infrastructure.
Closes #4988 by reintroducing a definition for "similar-origin window
agent", separate from its creation algorithm. Like the definition of all
agent types, it is now informal, just stating what globals are contained
in the agent.
Relocates the site-related definitions to the "Origin" section of the
spec, adjacent to the "schemelessly same site" and "same site"
definitions.
Exposes some of the higher-level concepts here to the dev edition.
This will require changes to the service worker and worklet specs to use the new concepts; stay tuned for some PRs there.
I could have factored out the movement of the site stuff into a separate commit; let me know if that'd be preferable.
/browsers.html ( diff )
/browsing-the-web.html ( diff )
/index.html ( diff )
/infrastructure.html ( diff )
/origin.html ( diff )
/webappapis.html ( diff )
/window-object.html ( diff )
/workers.html ( diff )