Improve definition of currently focused area #5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like an improvement, however the next step suggests a document does not necessarily have a focused area, which isn't acknowledged anywhere else?
domenic
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
This LGTM as an editorial clarification. You could go further and turn "redo this step" into an explicit loop.
For the bigger problem: yes, it looks like it's not possible for the focused area of a document to be unset. The focus fixup rule will kick in and make it the viewport. I think the intention of this step is to change such cases into the iframe... but I wonder if it matches browsers. It doesn't help that the way this definition is used is pretty roundabout so it'd be hard to tell where the difference comes in.
domenic
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like an improvement, however the next step suggests a document does not necessarily have a focused area, which isn't acknowledged anywhere else?
/interaction.html ( diff )