Meta: add link-type-alternate as ID for rel=alternate #5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We use empty |
|
I just tested locally after dropping the code from wattsi which generates that error. Here’s the output: <h5 id=rel-alternate><span class=secno>4.6.6.1</span> <span
id=link-type-alternate></span>Link type "<dfn
data-dfn-for=link/rel,a/rel,area/rel data-dfn-type=attr-value
data-export=""><code>alternate</code></dfn>"<a href=#rel-alternate
class=self-link></a></h5>…which seems to look fine. And that makes the dfn popup behavior work just fine too, so it doesn’t regress anything afaict. So I kinda left wondering why that check/error were added to wattsi to begin with. Regardless, it seems like we could fix this just by dropping the conditional in the wattsi sources which is causing it. |
annevk
added a commit
to whatwg/wattsi
that referenced
this pull request
Aug 24, 2020
sideshowbarker
approved these changes
Aug 26, 2020
sideshowbarker
added a commit
to whatwg/wattsi
that referenced
this pull request
Aug 28, 2020
This change drops an error that Wattsi emits for the case where a heading has an empty span or dfn (that is, with no text content), followed by another span or dfn in the same heading. The current code appears to have been (for some reason that’s not obvious now) very intentionally written to report an error for exactly that case — but not for the case where of a heading with *non-empty* span or dfn followed by another span or dfn in the same heading. Without this case, Wattsi reports an error for a reasonable markup case like the one in whatwg/html#5855; that is, this: <h5 id="rel-alternate"><span id="link-type-alternate"></span>Link type "<dfn data-export="" data-dfn-for="link/rel,a/rel,area/rel" data-dfn-type="attr-value"><code data-x="rel-alternate">alternate</code></dfn>"</h5> It’s not at all obvious why we’d want a case like that to be an error.
sideshowbarker
added a commit
to whatwg/wattsi
that referenced
this pull request
Aug 28, 2020
This change drops an error that Wattsi emits for the case where a heading has an empty span or dfn (that is, with no text content), followed by another span or dfn in the same heading. The current code appears to have been (for some reason that’s not obvious now) very intentionally written to report an error for exactly that case — but not for the case where of a heading with *non-empty* span or dfn followed by another span or dfn in the same heading. Without this change, Wattsi reports an error for a reasonable markup case like the one in whatwg/html#5855; that is, this: <h5 id="rel-alternate"><span id="link-type-alternate"></span>Link type "<dfn data-export="" data-dfn-for="link/rel,a/rel,area/rel" data-dfn-type="attr-value"><code data-x="rel-alternate">alternate</code></dfn>"</h5> It’s not at all obvious why we’d want a case like that to be an error.
sideshowbarker
added a commit
to whatwg/wattsi
that referenced
this pull request
Aug 29, 2020
This change drops an error that Wattsi emits for the case where a heading has an empty span or dfn (that is, with no text content), followed by another span or dfn in the same heading. The current code appears to have been (for some reason that’s not obvious now) very intentionally written to report an error for exactly that case — but not for the case where of a heading with *non-empty* span or dfn followed by another span or dfn in the same heading. Without this change, Wattsi reports an error for a reasonable markup case like the one in whatwg/html#5855; that is, this: <h5 id="rel-alternate"><span id="link-type-alternate"></span>Link type "<dfn data-export="" data-dfn-for="link/rel,a/rel,area/rel" data-dfn-type="attr-value"><code data-x="rel-alternate">alternate</code></dfn>"</h5> It’s not at all obvious why we’d want a case like that to be an error.
The former W3C fork changed the rel-alternate ID and now links to there redirect to the HTML Standard and end up leading nowhere. See protocol-registries/link-relations#22.
annevk
force-pushed
the
annevk/link-type-alternate
branch
from
04e2c90
to
a04c882
Compare
|
So PR Preview still fails somehow. Could that be because some server component isn't updated or something else? |
Yeah, I vaguely recall it breaking before in a case like this — but don’t recall who was able to fix it. As far as I know, I don’t myself have access to the shell environment or config UI for it. |
|
Sorry, yes, I always need to SSH into wattsi-server and re-update it manually. I should really automate that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former W3C fork changed the rel-alternate ID and now links to there redirect to the HTML Standard and end up leading nowhere.
See protocol-registries/link-relations#22.
/links.html ( diff )