Fix autocapitalize getter #5911
Conversation
There was a problem hiding this comment.
Hmm. I don't really find the current text ambiguous. "The string value corresponding to sentences" is clearly "sentences". So the last step here seems to subsume the previous two.
Since this confused an implementer, we clearly need to do something, but I'm worried that the new text is also a bit confusing.
I guess we could match the reflection text and say "the keyword value associated with state"? At least then the two other steps are non-redundant, because such a phrase is ambiguous for the sentences state.
source
Outdated
| empty string.</p></li> | ||
|
|
||
| <li><p>If <var>state</var> is <span data-x="autocap-hint-none">none</span>, then return | ||
| <code data-x="attr-autocapitalize-none">none</code>.</p></li> |
There was a problem hiding this comment.
quotes around strings, here and below?
There was a problem hiding this comment.
And not the other instances of these keywords? Shall I add them everywhere for these keywords and we'll use that for new things and whenever someone touches a keyword that's a string?
There was a problem hiding this comment.
Keywords are usually referenced as keywords. However, this is an IDL getter that returns a string. So it needs quotes. The fact that the thing inside those quotes is a keyword is interesting, and worth a cross-link, but it doesn't imply anything about other references to those keywords.
There was a problem hiding this comment.
I think I'd rather have all keywords marked up as strings all the time, but I did it this way for now.
annevk
force-pushed
the
annevk/autocapitalize-getter
branch
from
b52e5c3
to
87fdcf7
Compare
This was tested and such as part of #3273, but the text is ambiguous and we didn't catch that in review. Thanks @smaug----!
cc @rlanday
/interaction.html ( diff )