Unwrap the heading for the meta element section #5930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change unwraps the heading for the meta element section from <100 characters back to >100 characters. Otherwise, without this change, the .pre-process-tag-omission.pl script we use for generating the **Tag omission in text/html** subsections for every element section doesn’t work as expected for the meta element section. The reason is, that script is written to read in the source line-by-line and so doesn’t expect any headings to break across multiple lines.
This change adds an admonition in the CONTRIBUTING.md file about not wrapping element-section headings.
sideshowbarker
force-pushed
the
sideshowbarker/meta-element-section-heading-unwrap
branch
from
4b367c1
to
bee8505
Compare
|
I think actually I could also pretty easily add a check to the linter to catch this case and ensure we don’t regress it (again, as an alternative to doing the whatwg/html-build#250 fiddling with the perl script). |
|
Per reasoning in whatwg/html-build#250, I think it's better if we're able to linebreak headings like we do everything else, so I'll close this for now... thanks for taking the time to show both approaches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch unwraps the heading for the
metaelement section from <100 characters back to >100 characters.Otherwise, without this change, the
.pre-process-tag-omission.plscript we use for generating the Tag omission in text/html subsections for every element section doesn’t work as expected for themetaelement section.The reason is, that script is written to read in the source line-by-line and so doesn’t expect any headings to break across multiple lines.
This patch also includes a change adding an admonition to
CONTRIBUTING.mdabout not wrapping element-section headings.This patch is an alternative to whatwg/html-build#250. I’d personally prefer we make this change to the source rather than that change to the script — because the
metaelement is actually the only element-section heading we currently have which is longer than breaks across lines. So it seems easier to just unwrap it back to a single line, rather than further touching that script (which is obviously fragile, and touching it risks introduced other regressions)./index.html ( diff )
/semantics.html ( diff )