Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: migrate to GitHub Actions #5945

Merged
merged 4 commits into from Sep 25, 2020
Merged

Meta: migrate to GitHub Actions #5945

merged 4 commits into from Sep 25, 2020

Conversation

domenic
Copy link
Member

@domenic domenic commented Sep 24, 2020

This takes advantage of the new CI build strategy in
whatwg/html-build#254.

Part of whatwg/meta#173.

This should work even before whatwg/html-build#254 is merged because I used my local machine to upload a whatwg/html-build image to Docker Hub. So, if this passes CI (i.e. if the build part works), I think we should try merging it (and see if the deploy part works).

@domenic
Copy link
Member Author

domenic commented Sep 24, 2020

@foolip I think there are also steps that need to be done in the repository config? I guess around required build checks and stuff?

@domenic domenic force-pushed the github-actions-2 branch 3 times, most recently from c77a34d to 63ff655 Compare September 24, 2020 23:29
This takes advantage of the new CI build strategy in
whatwg/html-build#254.

Part of whatwg/meta#173.
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd try the deploy step by pushing to a branch with a modified condition as well, with --dry-run or something to make it a no-op.

@domenic domenic merged commit ff8cb6e into master Sep 25, 2020
@domenic domenic deleted the github-actions-2 branch September 25, 2020 15:24
domenic added a commit to whatwg/html-build that referenced this pull request Sep 25, 2020
Per the plan in whatwg/meta#173 (comment), this revamps the CI build to reduce coupling between the html-build and html repositories. Now, running CI (currently Travis) for the html-build repository produces a whatwg/html-build Docker container, pushed to Docker Hub, which can be given an input directory containing the contents of whatwg/html, and an output directory.

The corresponding changes in whatwg/html are in whatwg/html#5945.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants