Editorial: Update links in post-'resolve a module specifier' assertions #6031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns to point to where the prior 'resolve a module specifier' occurred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explanatory text of the assertion in HostResolveImportedModule stating that resolve a module specifier must have been previously successful lists HostImportModuleDynamically as one of the places where resolve a module specifier would previously have succeeded. However, it's fetch() an import() module script graph, called by HostImportModuleDynamically, where resolve a module specifier is actually called. Update the assertion text to reference fetch() an import() module script graph directly.
The corresponding assertion in find the first parse error didn't have a link to where the prior resolve a module specifier call would occur, so add one.
/webappapis.html ( diff )