Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove specification of intrinsic aspect-ratio, and instead map width… #6032

Merged
merged 6 commits into from
Feb 19, 2021
Merged

Remove specification of intrinsic aspect-ratio, and instead map width… #6032

merged 6 commits into from
Feb 19, 2021

Commits on Oct 5, 2020

  1. Remove specification of intrinsic aspect-ratio, and instead map width… 

    …/height to a presentational property. Fixes #5907
    @tabatkins
    tabatkins committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    e41e59b View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Tell Wattsi that the property value isn't a link.

    @tabatkins
    tabatkins committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    06a898e View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2020

  1. Now that aspect-ratio treats 0 or infinite ratios as an error case, l… 

    …imit the parsing to nonzero.
    @tabatkins
    tabatkins committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    5647ac4 View commit details
    Browse the repository at this point in the history

  2. Make it clear that the parsed number should be a px length.

    @tabatkins
    tabatkins committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    e9dcb08 View commit details
    Browse the repository at this point in the history

  3. Specify that the mapping also applies to video, canvas, and image but… 

    …ton elements, per CSSWG resolution.
    @tabatkins
    tabatkins committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    632c6f4 View commit details
    Browse the repository at this point in the history

  4. Oh duh, right, aspect ratios are unitless anyway.

    @tabatkins
    tabatkins committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    d14efd5 View commit details
    Browse the repository at this point in the history