New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDITORIAL: Update emacs & vim modeline. #6096
Conversation
1. Move emacs & vim modeline to the end of the file. This is not an important part of the spec, so it doesn't deserve being put at the front. 2. Set the vim filetype to be html. Depending on the developers configuration, this usually brings the HTML syntax color. 3. Set the vim column-column to be 100. This is for being consistent with the emacs's modeline.
Is this redundant with |
Thanks for your reply!
I wasn't aware of the existence of https://editorconfig.org/ I will let you choose what you prefer in between keeping or not this modelines. My patch was about moving/updating existing modeslines. It started to become painful entering vim commands to get colors ;-) |
Instead of removing the modeline, I’d personally rather we added it to our other standards. The benefit of the modeline is that it’s one single line that’s extremely simple and minimal (by design) yet has the effect of making the most important thing we want work in both vim and emacs right out of the box — without any vim or emacs users needing to do any special configuration to make it happen — whereas enabling support for All that said, I would rather we removed the modeline completely rather than adding to it further. So I don’t support merging the change in this PR (which anyway are changes that’ll only have effect in vim but not in emacs). |
It's up to you. Should I abandon this PR? |
@domenic should decide. |
I tend to agree that, if anything, we should delete these. Giving special treatment to vim/emacs, while all other text editors standardize on using editorconfig, seems wrong. Let's close this PR. Sorry @ArthurSonzogni! |
Thanks for taking a decision. No worries, I was not very attached to it. |
Move emacs & vim modeline to the end of the file. This is not an
important part of the spec, so it doesn't deserve being put at the
front.
Set the vim filetype to be html. Depending on the developers
configuration, this usually brings the HTML syntax color.
Set the vim color-column to be 100. This is for consistency
with emacs's modeline.
/acknowledgements.html ( diff )