-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all plugin-related APIs no-ops #6296
Conversation
6eb7e83
to
abf3fea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice. I hope we can remove some of these interfaces down the line, but this is a great start.
abf3fea
to
91587f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, a cleanup bug against Firefox would be nice. Will you also file a follow-up issue on Plugin and MimeType?
It might be worth waiting with landing this until Chrome is a bit further along, just to be sure. |
@mfreed7 did your change to Chrome come with web platform tests? |
@domenic no, sorry, I didn't include any WPTs for this. I did make a layout test that could easily be converted to a WPT. Should I do that? I'm still in "monitoring" mode for this change, with some anticipation of PDF-related problems, due to this comment. But I'm happy to move that test over to WPT if you think it would be valuable now. |
Yeah, converting that test would be ideal! |
91587f4
to
6494be3
Compare
@mfreed7 ping on converting that layout test to a WPT? |
Yep, thanks for the ping. I was waiting to see how back the fallout was for the original change, but it seems (??) like it might be ok. I'll convert this test to WPT today. |
This removes indexed property getters and thus removes Or maybe okay when we want to completely remove the interfaces. #6317 |
How could it cause web compat issues? |
|
I'm not sure how worried we should be about that... |
@annevk said we probably want to keep it for now, but yeah, no data to prove whether it will be a real issue. |
If Chrome is removing them I'd be happy for Firefox to follow, to be clear. But it does mean behavior changes for us, contrary to OP. |
Part of #6003. /cc @mfreed7 @annevk
(See WHATWG Working Mode: Changes for more details.)
/index.html ( diff )
/obsolete.html ( diff )
/system-state.html ( diff )