Modernize and refactor modal dialogs #6330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains a small bug fix, in that confirm() and prompt() said "return" in some cases instead of "return false" or "return null" as appropriate. Other notable changes, all editorial, are: * Factoring out repeated "cannot show modals" steps, which will likely expand over time (see e.g. #6297). * Separating out and explaining the no-argument overload of alert(). * Passing the document through to the "printing steps", instead of just having them talk about "this Window object".
annevk
approved these changes
Jan 27, 2021
| @@ -78763,7 +78763,7 @@ interface <dfn interface>Window</dfn> : <span>EventTarget</span> { | |||
| readonly attribute boolean <span data-x="dom-originAgentCluster">originAgentCluster</span>; | |||
|
|
|||
| // user prompts | |||
| undefined <span data-x="dom-alert">alert</span>(); | |||
| undefined <span data-x="dom-alert-noargs">alert</span>(); | |||
There was a problem hiding this comment.
What was the problem with treating this as a single method in prose? I much prefer that style.
There was a problem hiding this comment.
I don't think you can treat it as a single method, since there are two separate method declarations. As written before this patch, there was no definition for no-arg alert() in the spec.
| data-x="event-beforeprint">beforeprint</code> at the <span>relevant global object</span> of the | ||
| <code>Document</code> that is being printed, as well as any <span data-x="child browsing | ||
| data-x="event-beforeprint">beforeprint</code> at the <span>relevant global object</span> of | ||
| <var>document</var>, as well as any <span data-x="child browsing | ||
| context">child browsing contexts</span> in it.</p> |
There was a problem hiding this comment.
This is rather imprecise. Same for the after event.
There was a problem hiding this comment.
Yeah, I was wondering if you'd notice that... I didn't want to touch that here. I'll file a followup.
There was a problem hiding this comment.
Oh, we have one already: #5096
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a small bug fix, in that confirm() and prompt() said
"return" in some cases instead of "return false" or "return null" as
appropriate.
Other notable changes, all editorial, are:
expand over time (see e.g. Add early return to JS dialogs triggered from different origin-domain iframes #6297).
having them talk about "this Window object".
I will rebase #6297 if we merge this first.
/timers-and-user-prompts.html ( diff )
/window-object.html ( diff )