Allow not rendering nested browsing contexts #665
Conversation
|
@dbaron, is this something you can review on behalf of Mozilla? |
|
Review for what? It seems like a reasonable spec change (although I didn't read that closely) to allow that sort of experiment, which seems like a reasonable thing to want to experiment with. |
|
@dbaron mostly that, whether we're okay with this or see some kind of problem. |
| <p class="note">As with <span data-x="top-level browsing context">top-level browsing | ||
| contexts</span>, a variety of factors can influence whether it is profitable for a browser to | ||
| update the rendering of <span data-x="nested browsing context">nested browsing | ||
| contexts</span>. For example, a user agent may wish to spend less resources rendering |
There was a problem hiding this comment.
Cannot use "may" in a note. Use "might"?
There was a problem hiding this comment.
Fixed. I really need a lint check for this...
domenic
force-pushed
the
dont-paint-some-iframes
branch
from
532f7e7
to
fddfb1b
Compare
| <var>docs</var> all <code>Document</code> objects whose <span | ||
| data-x="concept-document-bc">browsing context</span>'s <span>top-level browsing context</span> | ||
| is <var>B</var>.</p> | ||
| <p>If there are <span data-x="top-level browsing context">top-level browsing contexts</span> |
There was a problem hiding this comment.
Rephrased this to be plural instead of singular; as-is it seems like it could be read that the browser only gets to choose one top-level browsing context not to paint.
|
@dbaron I'm confused. I thought gecko already did this for offscreen frames? We're getting close to shipping our change to not run the rendering pipeline for offscreen frames and noticed that the spec needs updating. In either case, we clearly both agree with the spec change in question. :) |
|
@ojanvafai - I don't think we make separate decisions for subframes within a single browser tab (separate from the toplevel frame in the tab), although I could be wrong. I do think we use multiple factors to make the decisions about toplevel browser tabs, though; not just whether the tab is selected. |
|
So Gecko does have https://bugzilla.mozilla.org/show_bug.cgi?id=1145439 |
This change allows user agents to skip the "update the rendering" steps, not just for top-level browsing contexts, but also for individual nested browsing contexts within the top-level one. Chrome intends to experiment with this for third-party iframes outside the browser's viewport.
annevk
force-pushed
the
dont-paint-some-iframes
branch
from
fddfb1b
to
ee77b87
Compare
This change allows user agents to skip the "update the rendering" steps,
not just for top-level browsing contexts, but also for individual nested
browsing contexts within the top-level one. Chrome intends to experiment
with this for third-party iframes outside the browser's viewport.
/cc @ojanvafai