Make a deep copy when cloning a policy container #6671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that https://infra.spec.whatwg.org/#list-clone creates a shallow copy of the list, hence the current algorithm for cloning a policy container just clones references to the policies in the other CSP list. Since a CSP policy is immutable, this is not a problem in principle (at least at the moment). Nevertheless, I believe it is better to create a deep copy here.
/origin.html ( diff )