Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: mark up definitions of element attributes as such #6752

Merged
merged 3 commits into from Jun 9, 2021

Conversation

@domenic
Copy link
Member

domenic commented Jun 8, 2021

I'm surprised this is all that's left, but I guess a previous pass took care of many of these.

Is there a way you could wrap these paragraphs (in an automated fashion, presumably) as part of the change? https://github.com/domenic/rewrapper/blob/master/script.mjs has some hacky not-always-correct code that might help.

dontcallmedom added a commit to w3c/reffy that referenced this pull request Jun 9, 2021
dontcallmedom added a commit to w3c/reffy that referenced this pull request Jun 9, 2021
@dontcallmedom
Copy link
Contributor Author

re exhaustiveness, running the following code on the HTML-rendered spec should help find any remaining gaps:

new Set(
  [...document.getElementById("attributes-1")
    .querySelectorAll("tbody tr td:first-of-type a")]
  .map(a => a.href.split('#')[1])
  .filter(id => document.getElementById(id).dataset.dfnType !== "element-attr"))

(there are a few false positives, due to either inconsistent links to attributes or links to specific elements within the list of links to attributes definitions in the attributes index)

dontcallmedom added a commit to w3c/reffy that referenced this pull request Jun 9, 2021
@domenic domenic merged commit ec82ec3 into whatwg:main Jun 9, 2021
@dontcallmedom dontcallmedom deleted the set-dfn-type-6 branch June 10, 2021 06:32
tidoust pushed a commit to w3c/reffy that referenced this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants