Editorial: Link to `continue` description #7060

heppokofrontend · 2021-09-12T16:09:19Z

I linked to https://infra.spec.whatwg.org/#iteration-continue from continue to make it more clear.

I am grateful to Domenic Denicola for pointing out that I had misunderstood the meaning of continue on Twitter.

/acknowledgements.html ( diff )
/common-microsyntaxes.html ( diff )
/form-control-infrastructure.html ( diff )
/images.html ( diff )
/microdata.html ( diff )
/parsing.html ( diff )

I linked to https://infra.spec.whatwg.org/#iteration-continue from continue to make it more clear.

domenic

Thanks for this! However, you have edited review-drafts/2021-01.wattsi, and you need to instead edit source.

Additionally, it might be worth searching for other instances of Continue. and linking them in the same PR. That is optional though.

review-drafts/2021-01.wattsi

I linked to https://infra.spec.whatwg.org/#iteration-continue from continue to make it more clear.

This reverts commit cc591bb.

heppokofrontend

Thanks for this! However, you have edited review-drafts/2021-01.wattsi, and you need to instead edit source.

Sorry, I did a revert...

Additionally, it might be worth searching for other instances of Continue. and linking them in the same PR. That is optional though.

I understand.
I'll check to see if there are any other unlinked Continues.

I'll notify you again when I'm done!

review-drafts/2021-01.wattsi

I linked to https://infra.spec.whatwg.org/#iteration-continue from continue to make it more clear.

heppokofrontend · 2021-09-14T20:35:45Z

@domenic I have marked up all the "continues" that I could find with the span element!
But, I have a question.

Is "continue" in line 56604 and 56613 are meaning a variable? Or is it a statement?

domenic

Is "continue" in line 56604 and 56613 are meaning a variable? Or is it a statement?

These are variables, so no need to change them! They could be written as <var>shouldContinue</var> if that would be clearer?

I guess maybe the confusing thing here is that there are generally two senses in which specs use the word continue:

"Continue to the next part of the algorithm", i.e., don't return or throw an error or anything like that.
"Continue to the next iteration of the loop, skipping any subsequent steps in the loop body".

What I like about your PR is that it links all cases of (2) directly to the definition. Hopefully then it is clear that any unlinked case really means (1).

domenic · 2021-09-14T20:48:37Z

source

@@ -28416,7 +28416,7 @@ was an English &lt;a href="/wiki/Music_hall">music hall&lt;/a> singer, ...</code
     <li><p>If another instance of this algorithm for this <code>img</code> element was started after this instance
     (even if it aborted and is no longer running), then return.</p></li>

-     <li><p><span>Queue a microtask</span> to continue this algorithm.</p></li>
+      <li><p><span>Queue a microtask</span> to <span>continue</span> this algorithm.</p></li>


This is not correct; here we're not in a loop but instead using "continue" in a different sense.

I'm sorry, I fixed !

domenic · 2021-09-14T20:48:41Z

source

@@ -28497,7 +28497,7 @@ was an English &lt;a href="/wiki/Music_hall">music hall&lt;/a> singer, ...</code
   </li>

   <li><p><span>Queue a microtask</span> to perform the rest of this algorithm, allowing the <span
-   data-x="concept-task">task</span> that invoked this algorithm to continue.</p></li>
+   data-x="concept-task">task</span> that invoked this algorithm to <span>continue</span>.</p></li>


This is not correct; here we're not in a loop but instead using "continue" in a different sense.

domenic · 2021-09-14T20:49:37Z

source

@@ -29281,15 +29281,15 @@ was an English &lt;a href="/wiki/Music_hall">music hall&lt;/a> singer, ...</code
   from the end of <var>unparsed size</var>.
   If <var>unparsed size</var> is now empty,
   that is a <span data-x="concept-microsyntax-parse-error">parse error</span>;
-   continue to the next iteration of this algorithm.</p></li>
+   <span>continue</span> to the next iteration of this algorithm.</p></li>


Let's just say continue here, removing the "to the next iteration of this algorithm" since that is clear from the definition.

I fixed it that way.
I have an English question, should I it as follows in this case?

Continue.

Then continue.

If it's just a minor difference, I will keep this!

What you did here is perfect as-is, with lowercase continue. This is because of the semicolon ;. We would use "then" after a comma ,.

Line 56990 is a bit of an exception to this general principle but somehow it reads OK anyway.

Thank you kindly! I've learned them!

domenic · 2021-09-14T20:49:40Z

source


   <li><p>If the last <span>component value</span> in <var>unparsed size</var>
   is a valid non-negative <span>&lt;source-size-value></span>,
   let <var>size</var> be its value
   and remove the <span>component value</span> from <var>unparsed size</var>.
   Any CSS function other than the <span>math functions</span> is invalid.
   Otherwise, there is a <span data-x="concept-microsyntax-parse-error">parse error</span>;
-   continue to the next iteration of this algorithm.</p></li>
+   <span>continue</span> to the next iteration of this algorithm.</p></li>


Let's just say continue here, removing the "to the next iteration of this algorithm" since that is clear from the definition.

I fixed it that way.

domenic · 2021-09-14T20:49:44Z

source

@@ -29302,7 +29302,7 @@ was an English &lt;a href="/wiki/Music_hall">music hall&lt;/a> singer, ...</code
   as a <span>&lt;media-condition></span>.
   If it does not parse correctly,
   or it does parse correctly but the <span>&lt;media-condition></span> evaluates to false,
-   continue to the next iteration of this algorithm. <ref spec=MQ></p></li>
+   <span>continue</span> to the next iteration of this algorithm. <ref spec=MQ></p></li>


Let's just say continue here, removing the "to the next iteration of this algorithm" since that is clear from the definition.

I fixed it that way.

domenic · 2021-09-14T20:50:09Z

source

@@ -29427,7 +29427,7 @@ was an English &lt;a href="/wiki/Music_hall">music hall&lt;/a> singer, ...</code
   <li>
    <p>If the <span>list of available images</span> contains an entry for <var>key</var>,
    then set <var>image request</var>'s <span data-x="img-req-data">image data</span> to that of the entry.
-    Continue to the next step.</p>
+    <span>Continue</span> to the next step.</p>


This is not correct; here we're not in a loop but instead using "continue" in a different sense.

domenic · 2021-09-14T20:50:14Z

source

@@ -33843,7 +33843,7 @@ interface <dfn interface>MediaError</dfn> {
   (this <span data-x="delay the load event">delays the load event</span>).</p></li>

   <li><p><span>Await a stable state</span>, allowing the <span
-   data-x="concept-task">task</span> that invoked this algorithm to continue. The <span>synchronous
+   data-x="concept-task">task</span> that invoked this algorithm to <span>continue</span>. The <span>synchronous


This is not correct; here we're not in a loop but instead using "continue" in a different sense.

domenic · 2021-09-14T20:50:39Z

source

@@ -93677,7 +93677,7 @@ import "https://example.com/foo/../module2.mjs";</code></pre>
    <p>Stop <var>task</var>, allowing whatever algorithm that invoked it to resume.</p>

    <p class="note">This causes the <span>event loop</span>'s main set of steps or the <span>perform
-    a microtask checkpoint</span> algorithm to continue.</p>
+    a microtask checkpoint</span> algorithm to <span>continue</span>.</p>


This is not correct; here we're not in a loop but instead using "continue" in a different sense.

domenic · 2021-09-14T20:50:44Z

source

@@ -96093,7 +96093,7 @@ enum <dfn enum>DOMParserSupportedType</dfn> {
   <li><p>Let <var>task</var>'s <dfn>timer nesting level</dfn> be <var>nesting
   level</var>.</p></li>

-   <li><p>Return <var>handle</var>, and then continue running this algorithm
+   <li><p>Return <var>handle</var>, and then <span>continue</span> running this algorithm


This is not correct; here we're not in a loop but instead using "continue" in a different sense.

heppokofrontend · 2021-09-15T17:02:52Z

@domenic

These are variables, so no need to change them! They could be written as <var>shouldContinue</var> if that would be clearer?

I fixed it that way!

I guess maybe the confusing thing here is that there are generally two senses in which specs use the word continue:

"Continue to the next part of the algorithm", i.e., don't return or throw an error or anything like that.

"Continue to the next iteration of the loop, skipping any subsequent steps in the loop body".

Yes, For a beginner in English like me, it is difficult to understand difference the meaning of "Continue" in a sentence...
That's why I want to fix document to be as clear as possible with this PR!

What I like about your PR is that it links all cases of (2) directly to the definition. Hopefully then it is clear that any unlinked case really means (1).

Thanks for like this PR, and for your review comments!
I'm happy to contribute to HTML Spec.

Please let me know if there is anything else I should fix!

domenic

Looks great, thanks again!

Can you sign the agreement at https://participate.whatwg.org/agreement ? Then we will merge this.

domenic · 2021-09-15T22:15:11Z

source

@@ -29281,15 +29281,15 @@ was an English &lt;a href="/wiki/Music_hall">music hall&lt;/a> singer, ...</code
   from the end of <var>unparsed size</var>.
   If <var>unparsed size</var> is now empty,
   that is a <span data-x="concept-microsyntax-parse-error">parse error</span>;
-   continue to the next iteration of this algorithm.</p></li>
+   <span>continue</span> to the next iteration of this algorithm.</p></li>


What you did here is perfect as-is, with lowercase continue. This is because of the semicolon ;. We would use "then" after a comma ,.

Line 56990 is a bit of an exception to this general principle but somehow it reads OK anyway.

heppokofrontend · 2021-09-16T06:20:32Z

@domenic

Can you sign the agreement at https://participate.whatwg.org/agreement ? Then we will merge this.

Excuse me, I've read it.

I actually work for a company building websites, but the series of activities on here I've done so far are completely private and personal.

Still, is there any problem in choosing the following?

I represent that I do not work in the field of web technologies as an employee, contractor, or agent of another person or legal entity, and make this Agreement in my personal capacity only.

Also, the name in the signature should be not a account name or handle name, right? (I feel awkward asking this question personally... 🙈)

domenic · 2021-09-16T20:05:16Z

Still, is there any problem in choosing the following?

There is no problem with choosing that in your case.

What's important is actually not whether the activities are private or personal. Instead, we care about whether your job role is in the field of web technologies, as defined here:

"Field of Web Technologies" means the field of creating and influencing web standards and web technologies that could be adopted by the web community. "Field of web technologies" does not include implementation of web standards solely for the purpose of creating a website or app.

It sounds like you fall into the last category, so choosing the individual option in the agreement is good!

Also, the name in the signature should be not a account name or handle name, right?

Right, it should be the name you usually use to sign contracts with.

heppokofrontend · 2021-09-16T20:17:11Z

@domenic Thank you! I've send!

But, I wrote my name wrong...

domenic · 2021-09-16T20:41:17Z

You can edit your signature by sending a pull request that modifies https://github.com/whatwg/participant-data/blob/main/individuals.json

heppokofrontend · 2021-09-25T09:39:39Z

@domenic It's solved! Sorry I was too busy to reply.

It is signed!

domenic · 2021-10-12T20:54:58Z

@heppokofrontend so sorry for the delay! I went on vacation just as you resolved the issue on your end. My apologies for a long road to getting this landed.

Add some links

cc591bb

I linked to https://infra.spec.whatwg.org/#iteration-continue from continue to make it more clear.

domenic requested changes Sep 13, 2021

View reviewed changes

review-drafts/2021-01.wattsi Outdated Show resolved Hide resolved

heppokofrontend added 2 commits September 14, 2021 20:03

Add some links

826d4e4

I linked to https://infra.spec.whatwg.org/#iteration-continue from continue to make it more clear.

Revert "Add some links"

b34b35c

This reverts commit cc591bb.

heppokofrontend commented Sep 14, 2021

View reviewed changes

review-drafts/2021-01.wattsi Outdated Show resolved Hide resolved

Add some links whatwg#7060

d72f36d

I linked to https://infra.spec.whatwg.org/#iteration-continue from continue to make it more clear.

heppokofrontend requested a review from domenic September 14, 2021 20:38

domenic reviewed Sep 14, 2021

View reviewed changes

heppokofrontend added 5 commits September 16, 2021 01:07

Fix incorrect markup whatwg#7060

8a23f4a

Fix incorrect markup whatwg#7060

13e5d45

Fix incorrect markup whatwg#7060

f569565

Fixed redundant expressions whatwg#7060

a855c53

Make it easy to see that it's a variable whatwg#7060

c29a885

heppokofrontend requested a review from domenic September 15, 2021 17:03

domenic approved these changes Sep 15, 2021

View reviewed changes

heppokofrontend requested a review from domenic September 28, 2021 01:53

domenic merged commit e270c0a into whatwg:main Oct 12, 2021

annevk mentioned this pull request Oct 15, 2021

Update @hiroya-uga whatwg/participant-data#44

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Editorial: Link to `continue` description #7060

Editorial: Link to `continue` description #7060

heppokofrontend commented Sep 12, 2021 •

edited by pr-preview bot

domenic left a comment

heppokofrontend left a comment

heppokofrontend commented Sep 14, 2021

domenic left a comment

domenic Sep 14, 2021

heppokofrontend Sep 15, 2021

domenic Sep 14, 2021

heppokofrontend Sep 15, 2021

domenic Sep 14, 2021

heppokofrontend Sep 15, 2021

domenic Sep 15, 2021

heppokofrontend Sep 16, 2021

domenic Sep 14, 2021

heppokofrontend Sep 15, 2021

domenic Sep 14, 2021

heppokofrontend Sep 15, 2021

domenic Sep 14, 2021

heppokofrontend Sep 15, 2021

domenic Sep 14, 2021

heppokofrontend Sep 15, 2021

domenic Sep 14, 2021

heppokofrontend Sep 15, 2021

domenic Sep 14, 2021

heppokofrontend Sep 15, 2021

heppokofrontend commented Sep 15, 2021

domenic left a comment

domenic Sep 15, 2021

heppokofrontend commented Sep 16, 2021 •

edited

domenic commented Sep 16, 2021

heppokofrontend commented Sep 16, 2021 •

edited

domenic commented Sep 16, 2021

heppokofrontend commented Sep 25, 2021

domenic commented Oct 12, 2021

Editorial: Link to continue description #7060

Editorial: Link to continue description #7060

Conversation

heppokofrontend commented Sep 12, 2021 • edited by pr-preview bot

domenic left a comment

Choose a reason for hiding this comment

heppokofrontend left a comment

Choose a reason for hiding this comment

heppokofrontend commented Sep 14, 2021

domenic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

heppokofrontend commented Sep 15, 2021

domenic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

heppokofrontend commented Sep 16, 2021 • edited

domenic commented Sep 16, 2021

heppokofrontend commented Sep 16, 2021 • edited

domenic commented Sep 16, 2021

heppokofrontend commented Sep 25, 2021

domenic commented Oct 12, 2021

Editorial: Link to `continue` description #7060

Editorial: Link to `continue` description #7060

heppokofrontend commented Sep 12, 2021 •

edited by pr-preview bot

heppokofrontend commented Sep 16, 2021 •

edited

heppokofrontend commented Sep 16, 2021 •

edited