Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved #6205 issue #7061

Closed
wants to merge 1 commit into from
Closed

Resolved #6205 issue #7061

wants to merge 1 commit into from

Conversation

AnirbanBall
Copy link

@AnirbanBall AnirbanBall commented Sep 12, 2021

This pr Fixes #6205 by replacing all the "UA" to "user agent" which is used extensively throughout the text.

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chrome: …
    • Firefox: …
    • Safari: …

(See WHATWG Working Mode: Changes for more details.)


/dom.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )
/links.html ( diff )
/semantics.html ( diff )
/urls-and-fetching.html ( diff )

Copy link
Member

@Kaiido Kaiido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #6205 (comment)

Note that I didn't check if more occurrences have been missed, it's entirely possible since we can already see some in the revision excerpt.

@@ -1731,7 +1731,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute

<h4 id="xml">XML compatibility</h4>

<p id="html-namespace">To ease migration from HTML to XML, UAs conforming to this specification
<p id="html-namespace">To ease migration from HTML to XML, User Agents conforming to this specification
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and throughout, why this casing?
"user agent" is just fine and is already used everywhere else.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean to say I have to write UAs as user agent not user agents ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean "UA" as "user agent" and "UAs" as "user agents", don't use title-casing (Uppercase on all first letter) when not in a title.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey thanks buddy

source Show resolved Hide resolved
@@ -1943,13 +1943,13 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
from requirements regarding user interaction.</p>

<p class="note">Typical examples of non-interactive presentation user agents are printers
(static UAs) and overhead displays (dynamic UAs). It is expected that most static
(static UAs) and overhead displays (dynamic User Agents). It is expected that most static
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not the first one?

non-interactive presentation user agents will also opt to <a href="#non-scripted">lack scripting
support</a>.</p>

<p class="example">A non-interactive but dynamic presentation UA would still execute scripts,
<p class="example">A non-interactive but dynamic presentation User Agents would still execute scripts,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here an below, why plural now?

@AnirbanBall AnirbanBall deleted the sahi branch September 13, 2021 03:54
@Kaiido Kaiido mentioned this pull request Sep 13, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Missing list of abbreviations
2 participants