Reference RFC 7578 instead of RFC 2388 #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 2388 has been obsoleted by RFC 7578. Fixes whatwg#398 * Remove note about non-usage of multipart/mixed, since the new RFC no longer recommends it either: > § 4.3. Multiple Files for One Form Field > [...] [RFC2388] suggested that multiple files for a single form field be > transmitted using a nested "multipart/mixed" part. This usage is > deprecated. * Remove remark about field names not using RFC 2047's 7-bit-safe "encoded-word" encoding method, since the new RFC no longer recommends it: > § 5.1. Non-ASCII Field Names and Values > [...] While [RFC2388] suggested that non-ASCII field names be encoded according > to the method in [RFC2047], this practice doesn't seem to have been > followed widely. * Remove requirement about not using RFC 2231 encoding for filenames, since the new RFC no longer recommends that encoding.
|
This LGTM. @annevk, do you want to give it a quick look, since I believe you were looking at nearby stuff in your encoding changes? |
|
I think this is probably a net improvement, though this new RFC still doesn't give us everything we need. We might have to just write our own algorithms at some point to cater for Fetch and encoding handling in the fringes. |
|
Thanks very much @cvrebert! We really appreciate this kind of cleanup <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398.
Submitted per #398 (comment)