Fix #715: clarify how aborting a running script works #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me. |
|
Awesome. Will leave unmerged until sometime tomorrow in case any of the other editors want to check it over. |
| <p>If the "<span>kill a worker</span>" or "<span>terminate a worker</span>" algorithms abort | ||
| the script then abort all these steps.</p> | ||
| <p>If the "<span>kill a worker</span>" or "<span>terminate a worker</span>" algorithms <span | ||
| data-x="abort a running script">abort</span> the script then abort all these steps.</p> |
There was a problem hiding this comment.
Do we still need to have this line given that this is technically handled in the paragraph above?
There was a problem hiding this comment.
Hmm yeah I think you're right. Removing.
|
LGTM. Perhaps file a bug upstream to figure out if TC39 finds this worthy of some words? |
domenic
force-pushed
the
script-aborting
branch
from
da49b60
to
6a48bfb
Compare
|
Filed tc39/ecma262#401. I also messed up this merge a tiny bit by pushing to master before pushing to this branch, so, for posterity the commit is 6a48bfb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it wasn't clear exactly which parts of the processing model
the vague phrase "abort the script" impacted. This gives us a specific
term that at least outlines the concept, and makes all other places
that are impacted by script abortion reference that term.
@bzbarsky to review