Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/nonzero #7194

Merged
merged 7 commits into from
Oct 12, 2021
Merged

docs/nonzero #7194

merged 7 commits into from
Oct 12, 2021

Conversation

j9t
Copy link
Contributor

@j9t j9t commented Oct 10, 2021

Made spelling of “nonzero” consistent with WHATWG Style Guide

Signed-off-by: Jens Oliver Meiert jens@meiert.com


/common-microsyntaxes.html ( diff )
/index.html ( diff )

* Fixed typo

Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
* Adjusted case (“wiki”—should otherwise be qualified for more clarity)
* Rephrased “microformats wiki existing-rel-values page” (super-long, reads awkwardly)
* Added article to make `source` element conditions more readable
* Limited repetition (double “and so forth”)
* Made layout/transparency note slightly more clear

Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We do want to preserve the old ID here though.

source Show resolved Hide resolved
Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
@j9t
Copy link
Contributor Author

j9t commented Oct 11, 2021

Thanks! We do want to preserve the old ID here though.

Missed this with the update—you mean the ID should say “non-zero”? (Will adjust my edit then, had used “nonzero” there now.)

What do you mean by “old ID” though? As far as I see there was none before—or are there references from another repo, which I may miss?

@annevk
Copy link
Member

annevk commented Oct 12, 2021

The IDs are generated from the text. But if you change the text, you need to make the ID explicit to preserve it.

@annevk annevk merged commit 2abb4ac into whatwg:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants