Variable agentCluster is not defined in StructuredSerializeInternal
#7215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for noticing this. It seems this regressed in cbcf6ac. I think your language works and it matches what was introduced in c9d8983. It's perhaps slightly weird that for deserializing we still use the language introduced in b3f8779 (i.e., getting the agent cluster from the realm). I guess ultimately that depends on tc39/ecma262#1357 getting fixed. cc @syg |
|
I guess the one request I have is that we inline this reference. We typically don't use variables if they only end up being used once. |
annevk
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*
(See WHATWG Working Mode: Changes for more details.)
/structured-data.html ( diff )