Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define algorithm for serializing a site #7251

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Define algorithm for serializing a site #7251

merged 6 commits into from
Oct 21, 2021

Conversation

apasel422
Copy link
Contributor

@apasel422 apasel422 commented Oct 20, 2021

Derived from the serialization of an origin.

Fixes #7250.

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chrome: …
    • Firefox: …
    • Safari: …

(See WHATWG Working Mode: Changes for more details.)


/acknowledgements.html ( diff )
/origin.html ( diff )

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable and per #7250 the motivation seems OK. I don't know if the Attribution Reporting API has multi-implementer interest, but my inclination (unless other editors disagree) is that for these kind of base primitives, it's usually OK to expose them even if their only consumer is a single-implementer spec.

source Show resolved Hide resolved
source Show resolved Hide resolved
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would like @annevk to also take a look.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One problem with this notation is that you need to know from context that it is a site. I think that's okay, but we should make note of it. Perhaps in a warning at the bottom?

(I also see that Infra might not support indexing syntax for tuples, but I'd consider that to be a bug. I'm pretty sure we already use that in places.)

source Show resolved Hide resolved
source Show resolved Hide resolved
@apasel422 apasel422 requested a review from annevk October 21, 2021 12:18
@annevk
Copy link
Member

annevk commented Oct 21, 2021

@apasel422 thanks, I think you might have missed my more general review comment?

annevk added a commit to whatwg/infra that referenced this pull request Oct 21, 2021
@apasel422
Copy link
Contributor Author

@apasel422 thanks, I think you might have missed my more general review comment?

Thanks, updated. Please take a look.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks good to me modulo a couple nits. I'll let @domenic do the honors later today.

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@apasel422 apasel422 requested a review from annevk October 21, 2021 12:54
@domenic domenic merged commit 4362342 into whatwg:main Oct 21, 2021
@apasel422 apasel422 deleted the serialize-site branch October 21, 2021 16:15
annevk added a commit to whatwg/infra that referenced this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Define serialization of a site
3 participants