-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define algorithm for serializing a site #7251
Conversation
Derived from the [serialization of an origin](https://html.spec.whatwg.org/multipage/origin.html#ascii-serialisation-of-an-origin).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable and per #7250 the motivation seems OK. I don't know if the Attribution Reporting API has multi-implementer interest, but my inclination (unless other editors disagree) is that for these kind of base primitives, it's usually OK to expose them even if their only consumer is a single-implementer spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would like @annevk to also take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One problem with this notation is that you need to know from context that it is a site. I think that's okay, but we should make note of it. Perhaps in a warning at the bottom?
(I also see that Infra might not support indexing syntax for tuples, but I'd consider that to be a bug. I'm pretty sure we already use that in places.)
@apasel422 thanks, I think you might have missed my more general review comment? |
See whatwg/html#7251 for context.
Thanks, updated. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that looks good to me modulo a couple nits. I'll let @domenic do the honors later today.
See whatwg/html#7251 for context.
Derived from the serialization of an origin.
Fixes #7250.
(See WHATWG Working Mode: Changes for more details.)
/acknowledgements.html ( diff )
/origin.html ( diff )