Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementInternals: The validationMessage attribute's getter throws exception #7281

Merged
merged 4 commits into from
Nov 2, 2021

Conversation

EdgarChen
Copy link
Member

@EdgarChen EdgarChen commented Nov 1, 2021

Align with other constraint validation attribute or method of ElementInternals interface,
which would throw "NotSupportedError" if the target element is not a form-associated
custom element.

Test also expects this.


(See WHATWG Working Mode: Changes for more details.)


/custom-elements.html ( diff )

…eption

Like other constraint validation attribute or method of ElementInternals interface
would throw "NotSupportedError" if the target element is not a form-associated
custom element.

[Test](https://github.com/web-platform-tests/wpt/blob/ff0fb2a6a742d2c9a1abcf9723382dac04979ce6/custom-elements/form-associated/ElementInternals-NotSupportedError.html#L17) also expects this.
@EdgarChen EdgarChen force-pushed the elementinternals-validationmessage branch from 2f1156e to 7056f8e Compare November 1, 2021 13:58
@EdgarChen EdgarChen marked this pull request as ready for review November 1, 2021 14:01
@EdgarChen
Copy link
Member Author

cc @domenic

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normatively LGTM; seems like a straightforward omission. Let's just tidy up the prose.

If you could fill out the PR template as well that'd be good. (Most boxes should be trivially checked since it already is implemented this way.)

source Show resolved Hide resolved
@annevk
Copy link
Member

annevk commented Nov 2, 2021

Drive-by nit: the first list item is indented with two spaces, instead of one.

@domenic domenic added topic: custom elements Relates to custom elements (as defined in DOM and HTML) topic: forms labels Nov 2, 2021
@domenic domenic merged commit 2864846 into whatwg:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: custom elements Relates to custom elements (as defined in DOM and HTML) topic: forms
Development

Successfully merging this pull request may close these issues.

None yet

3 participants