Define "document base URL" as a URL record, not a string #7298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define document base URL as a URL record instead of a string. Fixes whatwg#7297
|
@rdeltour hey, can you sign https://participate.whatwg.org/agreement? |
I asked https://github.com/daisy to sign it when I created the PR. |
|
Happy to wait. 😊 |
domenic
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document base URL was defined as an absolute URL which is a string. But it is used, and algorithmically defined, as a URL record. This PR changes the defined type of document base URL to URL record.
Fixes #7297
Although the change is theoretically normative (it modifies the defined type of a term) I think it can be considered as editorial. It does not require changes to implementations.
/acknowledgements.html ( diff )
/urls-and-fetching.html ( diff )