-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: export page visibilty concepts #7337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, but I think it'd be a bit nicer if we didn't have the shorthands. WDYT?
If it's ok, I'd like to keep the shorthands. I had them in the original Page Visibility document and I'm using them in some specs already. I personally find it convenient to conceptually write, for example, "if the document is [=document/visible=]... ", versus, "If the document's [=document/visibility state=] is "visible"...". However, it it sets bad precedence, I can remove them (or please delete them directly via a suggestion). |
Can you give some examples so we can see how widely-used that kind of shortcut is? I couldn't find any myself when quickly poking around. I think it's slightly suboptimal to talk about a document being hidden instead of talking about its visiblity state, as without following the link one might think it's a general idea of hiddenness instead of the very specific definition given here. But it doesn't matter that much. |
A not so great example (I’m the process of rewriting the visibility part to use the visibility change algo, but let’s use it for discussion): |
Any examples that aren't in need of rewriting anyway? :) |
No. The other one I thought was using the shorthands was Screen Wake Lock, but turns out it’s using “visibility state”. I’ll remove them as then it’s only Geo, and I’m rewriting it. |
Closes #7336
/interaction.html ( diff )