Update :active and :hover definitions #7465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches Gecko and WebKit. The disabled condition was added to the spec in 9985973 but not implemented uniformly. As discussed in #6635, it doesn't work very well and is inconsistent with other similar pseudo-classes, like :hover. This also removes the consideration of <link> elements with href="" attributes, since they no longer have activation behavior as of 1e0ee7f. And it updates the definitions of both :active and :hover to be based on the latest Selectors spec, which notably includes the ancestor condition over the flat tree at the CSS layer, instead of having HTML handle that. There remains some lack of interop around elements such as <input type=radio> which have activation behavior but are not on the list of elements for which "in a formal activation state" is considered. #6635 stays open to track that case.
domenic
added
normative change
topic: rendering
topic: forms
interop
annevk
reviewed
Jan 7, 2022
There was a problem hiding this comment.
I don't think the change for :hover works. This would mean that any ancestor of a labeled control of a label element that matchines :hover would also match :hover.
I'm also surprised these use the flat tree, though I suppose that makes some sense given the way events work.
|
Yeah, indeed that is not the case. https://jsbin.com/dibasoqali/edit?html,output I guess we need to separately define "matching :hover" (works on labels) and "while the user designates". |
domenic
changed the title
annevk
reviewed
Jan 12, 2022
domenic
added
the
needs tests
|
Alright, I filed https://bugs.chromium.org/p/chromium/issues/detail?id=1287171 and hopefully that will cause some WPTs to get written, so we can merge this. |
|
WPTs here: web-platform-tests/wpt#32804 |
|
Yay, thanks so much! I'll merge this now. |
domenic
removed
the
needs tests
mfreed7
pushed a commit
to mfreed7/html
that referenced
this pull request
Jun 3, 2022
This removes the disabled condition for :active, matching Gecko and WebKit. The condition was added to the spec in 9985973 but not implemented uniformly. As discussed in whatwg#6635, it doesn't work very well and is inconsistent with other similar pseudo-classes, like :hover. This also removes the consideration of <link> elements with href="" attributes for :active, since they no longer have activation behavior as of 1e0ee7f. Finally, this updates the definitions of both :active and :hover to be based on the latest Selectors spec, which notably includes the ancestor condition over the flat tree at the CSS layer, instead of having HTML handle that. This required splitting up "being activated" and "matches :active", as well as "designated" and "matches :hover". Closes whatwg#6635, although note that there remain other interop issues with :active, tracked in whatwg#7578.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the disabled condition for :active, matching Gecko and WebKit. The condition was added to the spec in 9985973 but not implemented uniformly. As discussed in #6635, it doesn't work very well and is inconsistent with other similar pseudo-classes, like :hover.
This also removes the consideration of
<link>elements with href="" attributes for :active, since they no longer have activation behavior as of 1e0ee7f.Finally, this updates the definitions of both :active and :hover to be based on the latest Selectors spec, which notably includes the ancestor condition over the flat tree at the CSS layer, instead of having HTML handle that. This required splitting up "being activated" and "matches :active", as well as "designated" and "matches :hover".
Closes #6635, although note that there remain other interop issues with :active, tracked in #7578.
(See WHATWG Working Mode: Changes for more details.)
We could consider resolving the
<input type=radio>case alongside this one in a single PR, but for now I'm tackling this alone./semantics-other.html ( diff )