Add <style>'s disabled IDL attribute #7779

domfarolino · 2022-04-04T03:13:30Z

This PR adds back the HTMLStyleElement's disabled IDL attribute. All browsers implement this, however unlike HTMLLinkElement, no browsers implement a disabled content attribute.

Note that this was originally tracked by #1081. That issue was closed #4519, though it did not spec anything <style> related.

At least two implementers are interested (and none opposed) (all already implement this IDL attribute):
- Chrome
- Firefox
- Safari
Tests are written and can be reviewed and commented upon at:
- https://github.com/web-platform-tests/wpt/blob/master/css/cssom/style-sheet-interfaces-001.html
Implementation bugs are filed:
- Chrome: https://crbug.com/695984; this is related to this issue, though there doesn't seem to be anything to implement, so it is really just tracking the task this PR fixes

/infrastructure.html ( diff )
/links.html ( diff )
/semantics.html ( diff )

source

domfarolino · 2022-04-07T04:51:42Z

I think this should be ready for another look spec-wise. I will confirm tomorrow whether or not the existing tests cover the case I outline in the example, and if not I will add one.

annevk

@emilio want to quickly double check this?

source

domfarolino · 2022-04-08T04:29:49Z

The case where we set disabled = true before <style> has an associated sheet is not tested via WPT. To try this, I implemented HTMLStyleElement in Blink in a way that would allow disabled mutations before an associated sheet is created. This way disabled would actually return true before the underlying sheet exists, and upon insertion the style would start out disabled. I found that an old (I think) WebKit test that Blink has inherited does test part of this 1. I'll port it over to WPT sometime over the next couple of days (I am out Friday).

domfarolino · 2022-04-08T16:55:22Z

I've uploaded https://crrev.com/c/3577899 to introduce a WPT that tests disabled setter before CSSStyleSheet creation.

This is all the work required to land whatwg/html#7779 and close https://crbug.com/695984. R=masonf@chromium.org Bug: 695984 Change-Id: I43b56a50c3dc8bf00e2b0f7e030a5a1b5095b2c0

emilio

Looks good, thanks!

This is all the work required to land whatwg/html#7779 and close https://crbug.com/695984. R=masonf@chromium.org Bug: 695984 Change-Id: I43b56a50c3dc8bf00e2b0f7e030a5a1b5095b2c0

This is all the work required to land whatwg/html#7779 and close https://crbug.com/695984. R=masonf@chromium.org Bug: 695984 Change-Id: I43b56a50c3dc8bf00e2b0f7e030a5a1b5095b2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3577899 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#990764}

domfarolino · 2022-04-11T14:52:29Z

The tests have been merged, and I uploaded w3c/svgwg#879 for SVGStyleElement.

domenic

Great retro-specification work; thanks for taking care of this years-old gap!

…bled setter, a=testonly Automatic update from web-platform-tests Blink: Add WPT for HTMLStyleElement#disabled setter This is all the work required to land whatwg/html#7779 and close https://crbug.com/695984. R=masonf@chromium.org Bug: 695984 Change-Id: I43b56a50c3dc8bf00e2b0f7e030a5a1b5095b2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3577899 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#990764} -- wpt-commits: 0d6ebf3f44c68879fe2459c8a313005fae078639 wpt-pr: 33569

whatwg/html#7779

This is all the work required to land whatwg/html#7779 and close https://crbug.com/695984. R=masonf@chromium.org Bug: 695984 Change-Id: I43b56a50c3dc8bf00e2b0f7e030a5a1b5095b2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3577899 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#990764}

This is all the work required to land whatwg/html#7779 and close https://crbug.com/695984. R=masonf@chromium.org Bug: 695984 Change-Id: I43b56a50c3dc8bf00e2b0f7e030a5a1b5095b2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3577899 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#990764} NOKEYCHECK=True GitOrigin-RevId: 9be30b412651759d43b0e5dee12848a0d521dc06

This CL is a follow-up to whatwg/html#7779 which largely fixed crbug.com/695984 when we decided to standardize HTMLStyleElement#disabled. There is a lingering comment about removing the IDL attribute that this CL deletes. Bug: 695984 Change-Id: I0c63496063b4e71922d6fdc528d8e1f885a9b4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335038 Auto-Submit: Dominic Farolino <dom@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1116466}

domfarolino added 3 commits April 3, 2022 23:02

Add <style>'s disabled IDL attribute

f02e863

Typo

034fbfc

Fix historical typo

474f4a9

domfarolino commented Apr 4, 2022

View reviewed changes

source Show resolved Hide resolved

source Outdated Show resolved Hide resolved

domfarolino requested a review from domenic April 4, 2022 03:20

annevk reviewed Apr 4, 2022

View reviewed changes

source Show resolved Hide resolved

source Outdated Show resolved Hide resolved

domfarolino added 2 commits April 7, 2022 00:16

Remove CEReactions. Boolean

9f17b01

Example

e5223a8

annevk reviewed Apr 7, 2022

View reviewed changes

source Show resolved Hide resolved

source Show resolved Hide resolved

Address annevk review

fcb4e4e

chromium-wpt-export-bot mentioned this pull request Apr 8, 2022

Blink: Add WPT for HTMLStyleElement#disabled setter web-platform-tests/wpt#33569

Merged

emilio approved these changes Apr 8, 2022

View reviewed changes

domfarolino mentioned this pull request Apr 9, 2022

Add SVGStyleElement#disabled attribute w3c/svgwg#879

Merged

domenic added addition/proposal New features or enhancements topic: style labels Apr 11, 2022

domenic approved these changes Apr 11, 2022

View reviewed changes

domenic merged commit 3b5c55f into main Apr 11, 2022

domenic deleted the domfarolino/style-disabled branch April 11, 2022 15:20

saschanaz mentioned this pull request Apr 25, 2022

Define <style>'s disabled getter and setter #5590

Closed

saschanaz added a commit to saschanaz/types-web that referenced this pull request Apr 25, 2022

Remove redundant style.disabled addition

8224a3e

whatwg/html#7779

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add <style>'s disabled IDL attribute #7779

Add <style>'s disabled IDL attribute #7779

domfarolino commented Apr 4, 2022 •

edited by pr-preview bot

Loading

domfarolino commented Apr 7, 2022

annevk left a comment

domfarolino commented Apr 8, 2022

domfarolino commented Apr 8, 2022

emilio left a comment

domfarolino commented Apr 11, 2022

domenic left a comment

Add <style>'s disabled IDL attribute #7779

Add <style>'s disabled IDL attribute #7779

Conversation

domfarolino commented Apr 4, 2022 • edited by pr-preview bot Loading

domfarolino commented Apr 7, 2022

annevk left a comment

Choose a reason for hiding this comment

domfarolino commented Apr 8, 2022

domfarolino commented Apr 8, 2022

emilio left a comment

Choose a reason for hiding this comment

domfarolino commented Apr 11, 2022

domenic left a comment

Choose a reason for hiding this comment

domfarolino commented Apr 4, 2022 •

edited by pr-preview bot

Loading