Be clearer about documents in script execution #7842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only normative change here is to delay the load event of the script's preparation-time document, instead of its node document (which could change while the fetching is in progress). Closes #5160. Otherwise, this consists of cleanups to use more precise language for certain documents, thus closing #7589, and of the pending parsing-blocking script concept to use more imperative language.
|
LGTM, thank you! |
annevk
reviewed
Apr 26, 2022
| <p id="scriptTagParserResumes">At this stage, if there is a <span>pending parsing-blocking | ||
| script</span>, then:</p> | ||
| <p id="scriptTagParserResumes">At this stage, if the <span>pending parsing-blocking | ||
| script</span> is not null, then:</p> |
There was a problem hiding this comment.
From this point on the member is grabbed out of thin air again. Can that be fixed as well or is this part trickier?
There was a problem hiding this comment.
This is part of the parser, which seems to operate on ambient "parser" and "document" variables without ever really defining them (or their relationship). That should probably be done in a future overhaul.
annevk
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only normative change here is to delay the load event of the script's preparation-time document, instead of its node document (which could change while the fetching is in progress). Closes #5160.
Otherwise, this consists of cleanups to use more precise language for certain documents, thus closing #7589, and of the pending parsing-blocking script concept to use more imperative language.
@hiroshige-g feel free to review (but doing so is optional).
(See WHATWG Working Mode: Changes for more details.)
/dynamic-markup-insertion.html ( diff )
/parsing.html ( diff )
/scripting.html ( diff )
/xhtml.html ( diff )