Revert "Add CanvasFilter objects as possible 2D context filters" #7874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It did not have implementer agreement after all. This reverts commit 5db6a65.
|
@mysteryDate could you work marking the tests |
domenic
approved these changes
Apr 29, 2022
|
Thanks for the review @domenic! @mysteryDate @fserb it would be ideal if the test changes can be made this week or so, so the specification isn't incorrect for too long a period. @whatwg/canvas this may be of interest. |
|
I pushed a commit that lets us preserve the nice editorial updates. I also worked on a CL to rename the tests. However in the meantime @annevk has lost WHATWG participation status :). So @annevk, at your leisure (please enjoy your vacation!), please review my extra commit, and maybe sign up as an individual. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 22, 2022
The spec is being reverted per whatwg/html#7874 due to lack of multi-implementer interest. So, we need to rename the tests. Bug: 1169216 Change-Id: I059fa4c951f2076cffb562bf4a32d4e4284d3771
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 27, 2022
The spec is being reverted per whatwg/html#7874 due to lack of multi-implementer interest. So, we need to rename the tests. Bug: 1169216 Change-Id: I059fa4c951f2076cffb562bf4a32d4e4284d3771
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 27, 2022
The spec is being reverted per whatwg/html#7874 due to lack of multi-implementer interest. So, we need to rename the tests. Bug: 1169216 Change-Id: I059fa4c951f2076cffb562bf4a32d4e4284d3771
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 28, 2022
The spec is being reverted per whatwg/html#7874 due to lack of multi-implementer interest. So, we need to rename the tests. Bug: 1169216 Change-Id: I059fa4c951f2076cffb562bf4a32d4e4284d3771
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 28, 2022
The spec is being reverted per whatwg/html#7874 due to lack of multi-implementer interest. So, we need to rename the tests. Bug: 1169216 Change-Id: I059fa4c951f2076cffb562bf4a32d4e4284d3771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714402 Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#1018614}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 28, 2022
The spec is being reverted per whatwg/html#7874 due to lack of multi-implementer interest. So, we need to rename the tests. Bug: 1169216 Change-Id: I059fa4c951f2076cffb562bf4a32d4e4284d3771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714402 Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#1018614}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 4, 2022
…, a=testonly Automatic update from web-platform-tests Rename CanvasFilter WPTs to be tentative The spec is being reverted per whatwg/html#7874 due to lack of multi-implementer interest. So, we need to rename the tests. Bug: 1169216 Change-Id: I059fa4c951f2076cffb562bf4a32d4e4284d3771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714402 Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#1018614} -- wpt-commits: 0c579dc895666e989c046b706955ca19d1244c7d wpt-pr: 34536
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jul 7, 2022
…, a=testonly Automatic update from web-platform-tests Rename CanvasFilter WPTs to be tentative The spec is being reverted per whatwg/html#7874 due to lack of multi-implementer interest. So, we need to rename the tests. Bug: 1169216 Change-Id: I059fa4c951f2076cffb562bf4a32d4e4284d3771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714402 Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#1018614} -- wpt-commits: 0c579dc895666e989c046b706955ca19d1244c7d wpt-pr: 34536
|
I cannot review my own PR, but it looks okay to me. I have updated the IPR check as well. I wasn't sure if we still wanted to use the first commit for the commit message so I'll leave that for you to decide. |
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
The spec is being reverted per whatwg/html#7874 due to lack of multi-implementer interest. So, we need to rename the tests. Bug: 1169216 Change-Id: I059fa4c951f2076cffb562bf4a32d4e4284d3771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714402 Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#1018614} NOKEYCHECK=True GitOrigin-RevId: 08ace1810e694323dd0aa354baaf8a89e58b9bfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It did not have implementer agreement after all.
This reverts commit 5db6a65.
See comments starting at #5621 (comment).
CanvasFiltertests to tentative(See WHATWG Working Mode: Changes for more details.)
/canvas.html ( diff )
/infrastructure.html ( diff )