Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export HTMLTemplateElement's content. #7998

Closed
wants to merge 1 commit into from

Conversation

mozfreddyb
Copy link
Contributor

@mozfreddyb mozfreddyb commented Jun 10, 2022

This change is purely editorial.


/scripting.html ( diff )

@domenic
Copy link
Member

domenic commented Jun 10, 2022

This isn't necessary; all IDL attributes are already exported, as the build error shows.

(Also, in general when sending export PRs, it's best to describe why you want it, so that we know that the referring spec isn't reaching into HTML's internals unnecessarily. E.g., we don't export things for the sake of monkeypatch specs, or specs that will eventually be upstreamed into HTML.)

@annevk
Copy link
Member

annevk commented Jun 11, 2022

https://wicg.github.io/sanitizer-api/ needs to reference "template contents", but this is indeed adding export to the wrong concept. And yeah, I guess it won't need exporting as we'll merge that spec in.

@mozfreddyb
Copy link
Contributor Author

mozfreddyb commented Jun 13, 2022

I'm iterating on the Sanitizer before upstreaming, but given that it will be progressing relatively soon, I'm also OK with leaving that as a dangling reference until we get there. Thanks for the quick feedback.

@mozfreddyb mozfreddyb closed this Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants