Fix HostPromiseRejectionHandler when running script is null #8043
Conversation
Closes #8041, by falling back to the current settings object instead (similar to what the module-related host hooks do). This also includes minor editorial updates to HostPromiseRejectionTracker, mostly to link to more Infra terms.
|
I implemented this in our engine and it works as expected, even reporting unhandled Promise rejections to Sentry: <!DOCTYPE html>
<html>
<head>
</head>
<body onmessage="Promise.reject(new Error('test'))">
<iframe srcdoc="<script>window.parent.postMessage('hello world')</script>">
</iframe>
</body>
</html>However, in our case, I believe this happened for every unhandled promise rejection, as the promise rejection code is native and is entered from a native function from JavaScript, meaning the running execution context always had a null I went with WindowEventHandler event attributes above because |
Closes #8041, by falling back to the current settings object instead (similar to what the module-related host hooks do).
This also includes minor editorial updates to HostPromiseRejectionTracker, mostly to link to more Infra terms.
@Lubrsi you review would be appreciated, as well as any ideas on web platform tests we could write.
(See WHATWG Working Mode: Changes for more details.)
/webappapis.html ( diff )