-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta] Clean events index #8351
Conversation
This implements the rule suggested in whatwg#8340 to have the events table only include events that the HTML spec actually fires. Changes made: - Drop `click`, `contextmenu`, `copy`, `cut`, `input`, `paste`, `securitypolicyviolation` and `slotchange` entries from the table - Complete the Dependencies section to mention the `copy`, `cut` and `paste` events defined in Clipboard API and Events, the `slotchange` event (about to be) defined in DOM and the `securitypolicyviolation` (about to be) defined in CSP. - Add Clipboard API and Events to the list of references. - Drop the reference to Page Visibility and drop Page Visibility from the list of references. Pull request should only be merged once DOM and CSP get updated to define the `securitypolicyviolation` and `slotchange` events.
the external PRs this PR depends on have been merged, so this should also be ready to go |
I just noticed the HTML spec does fire the click event, e.g. in https://html.spec.whatwg.org/#activation:event-click-2 . So I guess we should keep it? |
Indeed. Looking at events defined elsewhere, I note that:
Other events defined elsewhere are referenced by the HTML spec but not fired, and do not appear in the table. Alternatively, I wonder whether the criteria for inclusion in the table shouldn't be amended to: the events that HTML fires, unless they are (or should be) defined in another spec. |
Sorry this may not help to write a clear definition, but it might be noted that the input event fired by HTML isn't the same as the one being defined by UI Events, the former (fired on non textual |
I like the criteria of "event HTML fires", even if it's defined elsewhere. So I think including click, input, and pointercancel is a good idea.
I think they are the same event; note HTML says
which I believe includes textual elements. We just have the problem of #682. |
As discussed in whatwg#8351 (comment), this update re-introduces the Usage: click COMMAND [options] Commands are as follows ('click COMMAND --help' for more): build Build a Click package. buildsource Build a Click source package. chroot Use and manage a Click chroot. contents Show the file-list contents of a Click package file. framework List available frameworks. hook Install or remove a Click system hook. info Show manifest information for a Click package. install Install a Click package (low-level; consider pkcon instead). list List installed Click packages. pkgdir Print the directory where a Click package is unpacked. register Register an installed Click package for a user. unregister Unregister an installed Click package for a user. verify Verify a Click package. Options: -h, --help show this help message and exit and entries to the table and adds an entry for the event that references Pointer Events. The update also adds introductory text to the index, mentioning that the list completes the media element events and drag-and-drop events. The note that followed the table was dropped as a result.
PR updated to incorporate all the events fired by the spec based on @tidoust 's #8351 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
whatwg/html@627ee28 (whatwg/html#8351) removed these events from the HTML event index.
whatwg/html@627ee28 (whatwg/html#8351) removed these events from the HTML event index.
whatwg/html@627ee28 (whatwg/html#8351) removed these events from the HTML event index.
This implements the rule suggested in #8340 to have the events table only include events that the HTML spec actually fires, based the analysis done by @tidoust.
Changes made:
click
,contextmenu
,copy
,cut
,input
,paste
,securitypolicyviolation
andslotchange
entries from the tablecopy
,cut
andpaste
events defined in Clipboard API and Events, theslotchange
event (about to be) defined in DOM and thesecuritypolicyviolation
(about to be) defined in CSP.Pull request should only be merged once DOM and CSP get updated to define the
securitypolicyviolation
andslotchange
events (marking it as draft in the meantime)./indices.html ( diff )
/infrastructure.html ( diff )
/references.html ( diff )
/webappapis.html ( diff )